search

GSTT-CSC / MLOps

Framework for building ML apps
GNU General Public License v3.0
9 stars 5 forks source link

docker install check not adequate #10

Closed hshuaib90 closed 3 years ago

hshuaib90 commented 3 years ago

In the README, checking docker is working by typing the command: docker --help is not enough as this can return correctly even if the docker server is not up and running.

Probably better to use something like: docker images ls

laurencejackson commented 3 years ago

I think there's some confusion here sorry, the docker --help command is just to check that docker is installed on the local machine. You're right though there is no post-installation check to ensure the server is running.

@tapjason can you create a step 3 in the getting started installation guide describing how to ensure the server is running. Either with docker ps or with a screenshot of the expected terminal output when the containers start successfully.