search

GSTT-CSC / MLOps

Framework for building ML apps
GNU General Public License v3.0
9 stars 5 forks source link

configure_minio should use os.environ not self.config #13

Closed hshuaib90 closed 2 years ago

hshuaib90 commented 3 years ago

The config_setup copies self.config values to environment variables using os.environ but then configure_minio goes back to self.config which means it fails to use the appropriate config. This is particularly an issues for when use_localhost=True. The correct code should be:

uri_formatted = os.environ['MLFLOW_S3_ENDPOINT_URL'].replace("http://", "")
user = os.environ['AWS_ACCESS_KEY_ID']
password = os.environ['AWS_SECRET_ACCESS_KEY']
alexandertdeng commented 2 years ago

35 I have updated configure_minio with the code above from @hshuaib90