Closed Lucrezia-Cester closed 7 months ago
Hi @tomaroberts , this PR is linked to an issue (see development issue) and I just solved the issue that was described
I will add a few words in the description and attach a screenshot soon
Database needs to be migrated to add the new column for task docstring
hi @hshuaib90, could you please take a look at this PR? I have added a column to the Task table to store docstring data.
When I try to use alembic to generate a migration I get this error
lce21@medphys026-mac hazen-web-app % alembic revision --autogenerate -m "Add docstring column to task table"
FAILED: No config file 'alembic.ini' found, or file has no '[alembic]' section
edit: when running from within the migration folder there is still errors. There is still a problem of running alembic outside the application. error: Working outside of application context.
EDIT2: migration worked. There were inconsistencies with previous migrations which had to be fixed. NO FURTHER HELP NEEDED HERE.
@hshuaib90, @heyhaleema , this is now ready for review, docstring is added to database in task table if the docstring is present in the original hazenlib task.
@tomaroberts, @heyhaleema, could this PR be reviewed please?
Task description will be described in the ReadTheDocs autogenerated from the hazenlib docstrings and additional descriptions by MR physicists to other users. This PR and change is no longer required.
@Lucrezia-Cester
Can you describe this PR a bit more for me please? And add a screenshot showing the change.
Also, you have committed your Python virtual environment with this PR – please can you remove it.