search

GSTT-CSC / hazen-web-app

Interactive web-based implementation of hazen
Other
0 stars 0 forks source link

108 add a unit test for docker compose #109

Closed laurencejackson closed 1 year ago

laurencejackson commented 1 year ago

Adds GH action to check build was successful

Can see the result when a container fails to start on this run where web app was forced to crash.: https://github.com/GSTT-CSC/hazen-web-app/actions/runs/4222786266

tomaroberts commented 1 year ago

@laurencejackson – how do you suggest I can test this PR? Guess I could merge and then make a rudimentary change and then check that it builds/passes?

laurencejackson commented 1 year ago

@laurencejackson – how do you suggest I can test this PR? Guess I could merge and then make a rudimentary change and then check that it builds/passes?

Not sure if you missed it, but in the description is a link to the results of the GHA that this POR creates with a broken webapp, which shows that the test will fail when a container doesn't have the status 'running' which should be the case most of the time when the app cannot start.

If you want to check for yourself its best not to merge into master for testing. Instead you could checkout this branch e.g. 108-tr-test, create a new commit where you break something, then open a PR and watch it fail, then close that PR without merging.