GSTT-CSC / hazen-web-app

Interactive web-based implementation of hazen
Other
0 stars 0 forks source link

Active link to new main #114

Closed Lucrezia-Cester closed 1 year ago

Lucrezia-Cester commented 1 year ago

I have closed the previous branch as it was out of sync with main and I have added the navbar commits to this new branch.

I have also fixed the navbar according to your 2 comments @tomaroberts which were:

1) change bg color 2) put edit profile and logout at the end of the tab

I attach 2 screenshots to show the changes and also that active link is working

Screenshot 2023-03-10 at 07 41 12 Screenshot 2023-03-10 at 07 41 19
Lucrezia-Cester commented 1 year ago

Hi @tomaroberts, @heyhaleema, this is now ready for review

heyhaleema commented 1 year ago

@Lucrezia-Cester I've just had a quick test of this and the core functionality works, but I just have a few notes/questions:

Lucrezia-Cester commented 1 year ago

Hi @heyhaleema, I just opened the branch associated with this PR (active_link_to_new_main) with github desktop and I get the correct results --> see attached pics. Could it be that you opened the old branch for the issue?

Screenshot 2023-03-24 at 13 39 41 Screenshot 2023-03-24 at 13 39 44 Screenshot 2023-03-24 at 13 39 49
Lucrezia-Cester commented 1 year ago

Also to venv to be added in the .gitignore files

Lucrezia-Cester commented 1 year ago

@heyhaleema, apologies I had not pushed the commits, all should be fixed now. Now this branch is updated with my github desktop one.