Updates config.py and README.md

GSTT-CSC / hazen-web-app

Interactive web-based implementation of hazen

Other

0 stars 0 forks source link

Updates config.py and README.md #2

Closed heyhaleema closed 2 years ago

heyhaleema commented 2 years ago

This PR:

Removes .replace("://", "ql://", 1) from SQLALCHEMY_DATABASE_URI assignment in config.py to fix AttributeError raised:
Adds clarification regarding Postgres application installation step pre-Postico application installation in README.md

tomaroberts commented 2 years ago

Ahh - thanks for this Haleema. This fixes running hazen-wep-app locally, but I'm not sure at this stage how it interacts when we go live on Heroku. So propose to sign off this PR once we've tested on Heroku further.

Also, at some point we will want to implement some GH Actions/Heroku synergy to automatically push changes to staging and production environments.

hshuaib90 commented 2 years ago

Also, at some point we will want to implement some GH Actions/Heroku synergy to automatically push changes to staging and production environments.

I would recommend setting up action to push to heroku sooner rather than later. How are you testing on Heroku at the moment? Using bitbucket? Or are you doing everything locally?

tomaroberts commented 2 years ago

I would recommend setting up action to push to heroku sooner rather than later. How are you testing on Heroku at the moment? Using bitbucket? Or are you doing everything locally?

Just working locally atm.

hshuaib90 commented 2 years ago

No worries, I've added the issue here #3

heyhaleema commented 2 years ago

Sounds good, @tomaroberts! I've just added a note on macOS Monterey's usage of port 5000 in the README and I'll be raising a separate PR to close #1 since the app now works for me.

heyhaleema commented 2 years ago

@tomaroberts I've reverted the change to config.py since this is included in PR #4 and so this PR now only includes the update to README.md.