Closed heyhaleema closed 2 years ago
hey @heyhaleema, as with #232, could you try rolling back the scipy and numpy versions on this PR and we can merge your changes if the tests then pass.
Coverage Report
File Stmts Miss Cover Missing hazenlib init.py 136 34 75% 137, 141, 151, 156, 193, 200–205, 216, 219–226, 246–248, 266–268, 287–289, 298, 303, 309, 339, 373–374 acr_uniformity.py 92 39 58% 91–107, 114–143, 147 ghosting.py 151 55 64% 24, 89–90, 94, 104–105, 133–135, 151–153, 215–248, 255–275, 280 relaxometry.py 317 90 72% 238–256, 630, 689–691, 745, 793–815, 833–848, 1173–1176, 1185–1188, 1200–1213, 1216–1221, 1233–1263 slice_position.py 110 20 82% 73–74, 99, 183, 190–203, 211, 219–220, 231 slice_width.py 378 61 84% 28, 31, 39–44, 47, 115, 173–191, 466, 471–472, 478, 483, 546–547, 782–821, 857–860, 863–866 snr.py 165 47 72% 42–47, 209–219, 262–266, 304–315, 321–329, 357–368, 392, 400–402, 405 snr_map.py 108 5 95% 403, 408–410, 440 spatial_resolution.py 293 91 69% 44–102, 116, 208, 248–255, 283, 416–449, 481–484, 488–491 tools.py 75 6 92% 43–50, 89 uniformity.py 79 22 72% 69–70, 77, 111–123, 135–137, 140, 144–147, 155 TOTAL 1940 470 76%
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
178 | 0 :zzz: | 0 :x: | 0 :fire: | 2m 35s :stopwatch: |
@heyhaleema
I see some changes to the requirements.txt and then you reverted them in response to Laurence. Not sure which version of the file you actually want in the main branch?
As the tests are now passing, can you update the file to whichever state you want and then we can merge the PR. Thanks.
@tomaroberts I've reverted all changes to requirements.txt and updated the PR title, so this branch should now only add the updates to README.md. Thanks to you and @laurencejackson for looking into this and #232!
This PR:
scikit-image
,scipy
,psycopg-binary
, andnumpy
package versions in requirements.txtThe above resolves the issue I had with running
pip install -r requirements.txt
and enables me to complete the installation steps and run the tests.