GSTT-CSC / hazen

Quality assurance framework for Magnetic Resonance Imaging
https://github.com/GSTT-CSC/hazen
Apache License 2.0
22 stars 12 forks source link

Adds M1 Apple Mac installation instructions #224

Closed heyhaleema closed 2 years ago

heyhaleema commented 2 years ago

This PR:

The above resolves the issue I had with running pip install -r requirements.txt and enables me to complete the installation steps and run the tests.

laurencejackson commented 2 years ago

hey @heyhaleema, as with #232, could you try rolling back the scipy and numpy versions on this PR and we can merge your changes if the tests then pass.

heyhaleema commented 2 years ago

Quoting comment from #232 regarding SNR test assertion failure in PR checks for visibility:

I think the issue is Ubuntu, particularly numpy* in that OS vs. macOS:

Screenshot 2022-04-27 at 11 40 55 PM
github-actions[bot] commented 2 years ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   init.py1363475%137, 141, 151, 156, 193, 200–205, 216, 219–226, 246–248, 266–268, 287–289, 298, 303, 309, 339, 373–374
   acr_uniformity.py923958%91–107, 114–143, 147
   ghosting.py1515564%24, 89–90, 94, 104–105, 133–135, 151–153, 215–248, 255–275, 280
   relaxometry.py3179072%238–256, 630, 689–691, 745, 793–815, 833–848, 1173–1176, 1185–1188, 1200–1213, 1216–1221, 1233–1263
   slice_position.py1102082%73–74, 99, 183, 190–203, 211, 219–220, 231
   slice_width.py3786184%28, 31, 39–44, 47, 115, 173–191, 466, 471–472, 478, 483, 546–547, 782–821, 857–860, 863–866
   snr.py1654772%42–47, 209–219, 262–266, 304–315, 321–329, 357–368, 392, 400–402, 405
   snr_map.py108595%403, 408–410, 440
   spatial_resolution.py2939169%44–102, 116, 208, 248–255, 283, 416–449, 481–484, 488–491
   tools.py75692%43–50, 89
   uniformity.py792272%69–70, 77, 111–123, 135–137, 140, 144–147, 155
TOTAL194047076% 

Tests Skipped Failures Errors Time
178 0 :zzz: 0 :x: 0 :fire: 2m 35s :stopwatch:
tomaroberts commented 2 years ago

@heyhaleema

I see some changes to the requirements.txt and then you reverted them in response to Laurence. Not sure which version of the file you actually want in the main branch?

As the tests are now passing, can you update the file to whichever state you want and then we can merge the PR. Thanks.

heyhaleema commented 2 years ago

@tomaroberts I've reverted all changes to requirements.txt and updated the PR title, so this branch should now only add the updates to README.md. Thanks to you and @laurencejackson for looking into this and #232!