GSTT-CSC / hazen

Quality assurance framework for Magnetic Resonance Imaging
https://github.com/GSTT-CSC/hazen
Apache License 2.0
22 stars 12 forks source link

Adds SNR test #232

Closed heyhaleema closed 1 year ago

heyhaleema commented 2 years ago

This PR adds test_two_inputs_match to test_snr.py.

tomaroberts commented 2 years ago

Tests failing on SNR assertion:

image
laurencejackson commented 2 years ago

@heyhaleema, could you try rolling back the scipy and numpy versions, making a new commit and pushing it again? I believe this is the only reason the build tests are failing, if they pass we can go ahead and merge your changes.

If they do pass we should look into how we can get these package versions running on your hardware so you can continue local testing.

heyhaleema commented 2 years ago

I think the issue is Ubuntu, particularly numpy* in that OS vs. macOS:

Screenshot 2022-04-27 at 11 40 55 PM

* Potentially! See this and this post.

github-actions[bot] commented 2 years ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   HazenTask.py25484%18, 32–34
   __init__.py1473874%141, 145, 155, 160, 197, 204–209, 220, 223–230, 250–252, 270–272, 291–293, 302, 307, 313, 364, 387–389, 397–398, 402
   exceptions.py21481%17–21
   relaxometry.py3179072%238–256, 631, 690–692, 746, 794–816, 834–849, 1174–1177, 1186–1189, 1201–1214, 1217–1222, 1233–1263
   shapes.py20955%13, 16, 24–29, 32
   snr_map.py111595%408, 413–415, 444
   tools.py84890%43–50, 92, 101, 117
hazenlib/tasks
   acr_ghosting.py1164264%33–53, 91–93, 123–125, 161–194
   acr_uniformity.py893264%34–54, 121–138
   ghosting.py1505166%18–32, 47, 109–110, 114, 124–125, 151–153, 170–172, 218–256
   relaxometry.py7271%10–11
   slice_position.py1182281%31, 40–41, 103–104, 130, 210, 217–234
   slice_width.py3565285%34–37, 107, 166–186, 451, 456–457, 463, 468, 530–531, 780–821
   snr.py1636660%62–67, 161–179, 194–203, 221–231, 258–268, 273–283, 314–327, 332–340, 369–382
   snr_map.py770%1–11
   spatial_resolution.py2464482%36–39, 62, 147, 206, 332–368
   uniformity.py781976%42–45, 91–92, 99, 133–147
TOTAL207149576% 

Tests Skipped Failures Errors Time
180 0 :zzz: 0 :x: 0 :fire: 2m 4s :stopwatch:
tomaroberts commented 2 years ago

@heyhaleema @laurencejackson

The tests for this branch are now passing... but I'm very confused. Basically all I did was re-run the Development tests and magically they are now passing...?!

tomaroberts commented 2 years ago

Have changed this to merge into release/0.7.0 branch rather than main as this PR includes code changes, whereas some of the other recent PR merges into main were just documentation alterations.

Lucrezia-Cester commented 1 year ago

@heyhaleema This branch is not out of date, could you please merge it to the new main?