Test failure: Test512Matrix.test_get_rods - Arrays are not almost equal to 4 decimals

GSTT-CSC / hazen

Quality assurance framework for Magnetic Resonance Imaging

https://github.com/GSTT-CSC/hazen

Apache License 2.0

22 stars 12 forks source link

Test failure: Test512Matrix.test_get_rods - Arrays are not almost equal to 4 decimals #269

Closed RFranklin-MR closed 1 year ago

RFranklin-MR commented 2 years ago

I ran the unit tests after installing hazen (master branch at 1/9/2022) on a Mac. One of the unit tests in test_slice_width.py: Test512Matrix.test_get_rods fails with the following error:

Please let me know if any further information is needed. This test failure doesn't seem serious (the values are equal to 3 decimals).

Lucrezia-Cester commented 1 year ago

Hi @RFranklin-MR, I have investigated this issue and found that the assert_almost_equal has already been changed to 3 decimal places rather than 4, so this issue should not be there. Are you using the latest version?

RFranklin-MR commented 1 year ago

This issue was in master on 1st September this year; if it has been changed since that time then this issue can be closed.

tomaroberts commented 1 year ago

Thanks for added info Rachael. I've just run pytest tests/test_slice_width.py locally and no errors. Will close issue – please raise again if see any more in future.