Closed Lucrezia-Cester closed 1 year ago
Coverage Report
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
180 | 0 :zzz: | 0 :x: | 0 :fire: | 2m 19s :stopwatch: |
Hi @heyhaleema, @laurencejackson, could you please review this PR? Thank you.
Hi @heyhaleema, could you review this PR please?
@heyhaleema, I feel like this should be in another PR as this is stuff i didn't personally add for this PR. I can add this in another issue and open a PR for this
@Lucrezia-Cester I think, ideally, every PR needs to pass our checks, regardless of whether its related to the PR-specific changes. In this case, I think if we can fix this in this PR, then it would ensure that anyone branching off main
would have these checks passing from the start.
Happy to contribute to this branch and do some tidying up, if that works? I'll also update this branch with merge commit to bring in changes from main
, if that's okay, too.
@heyhaleema ah yes, sorry, good point
@laurencejackson FYI, I've reviewed and approved @Lucrezia-Cester's changes, but do we want to also update the files with check annotations?
@laurencejackson FYI, I've reviewed and approved @Lucrezia-Cester's changes, but do we want to also update the files with check annotations?
If you mean the warnings raised by flake8 then its not urgent. It's useful for us to fix these as we go along to ensure some code standards but I think we can go ahead and merge this once the tests have passed.
added axes labels to scatter figure for slice_position task, solves issue https://github.com/GSTT-CSC/hazen/issues/234