GSTT-CSC / hazen

Quality assurance framework for Magnetic Resonance Imaging
https://github.com/GSTT-CSC/hazen
Apache License 2.0
22 stars 12 forks source link

Slice pos axis labels #279

Closed Lucrezia-Cester closed 1 year ago

Lucrezia-Cester commented 2 years ago

added axes labels to scatter figure for slice_position task, solves issue https://github.com/GSTT-CSC/hazen/issues/234

github-actions[bot] commented 2 years ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   HazenTask.py24388%29–31
   __init__.py1473874%136, 140, 150, 155, 192, 199–204, 215, 218–225, 245–247, 265–267, 286–288, 297, 302, 308, 359, 379–381, 389–390, 394
   exceptions.py21481%17–21
   relaxometry.py3179072%238–256, 631, 690–692, 746, 794–816, 834–849, 1174–1177, 1186–1189, 1201–1214, 1217–1222, 1233–1263
   shapes.py20955%13, 16, 24–29, 32
   snr_map.py108595%403, 408–410, 439
   tools.py84890%43–50, 92, 101, 117
hazenlib/tasks
   ghosting.py1505166%18–32, 47, 109–110, 114, 124–125, 151–153, 170–172, 218–256
   relaxometry.py7271%10–11
   slice_position.py1182281%31, 40–41, 103–104, 130, 210, 217–234
   slice_width.py3565285%34–37, 107, 166–186, 451, 456–457, 463, 468, 530–531, 780–821
   snr.py1636660%62–67, 161–179, 194–203, 221–231, 258–268, 273–283, 314–327, 332–340, 369–382
   snr_map.py770%1–11
   spatial_resolution.py2464482%36–39, 62, 147, 206, 332–368
   task_acr_ghosting.py1164264%33–53, 91–93, 123–125, 161–194
   task_acr_uniformity.py893264%34–54, 121–138
   uniformity.py781976%42–45, 91–92, 99, 133–147
TOTAL206749476% 

Tests Skipped Failures Errors Time
180 0 :zzz: 0 :x: 0 :fire: 2m 19s :stopwatch:
Lucrezia-Cester commented 2 years ago

Hi @heyhaleema, @laurencejackson, could you please review this PR? Thank you.

Lucrezia-Cester commented 2 years ago

Hi @heyhaleema, could you review this PR please?

Lucrezia-Cester commented 2 years ago

@heyhaleema, I feel like this should be in another PR as this is stuff i didn't personally add for this PR. I can add this in another issue and open a PR for this

heyhaleema commented 2 years ago

@Lucrezia-Cester I think, ideally, every PR needs to pass our checks, regardless of whether its related to the PR-specific changes. In this case, I think if we can fix this in this PR, then it would ensure that anyone branching off main would have these checks passing from the start.

Happy to contribute to this branch and do some tidying up, if that works? I'll also update this branch with merge commit to bring in changes from main, if that's okay, too.

Lucrezia-Cester commented 2 years ago

@heyhaleema ah yes, sorry, good point

heyhaleema commented 1 year ago

@laurencejackson FYI, I've reviewed and approved @Lucrezia-Cester's changes, but do we want to also update the files with check annotations?

laurencejackson commented 1 year ago

@laurencejackson FYI, I've reviewed and approved @Lucrezia-Cester's changes, but do we want to also update the files with check annotations?

If you mean the warnings raised by flake8 then its not urgent. It's useful for us to fix these as we go along to ensure some code standards but I think we can go ahead and merge this once the tests have passed.