GSTT-CSC / hazen

Quality assurance framework for Magnetic Resonance Imaging
https://github.com/GSTT-CSC/hazen
Apache License 2.0
22 stars 12 forks source link

360 relaxometry task report #361

Closed sophie22 closed 1 year ago

sophie22 commented 1 year ago

Potential fix for #360 by partially refactoring the relaxometry task to be closer aligned with other tasks, and especially fixing the way report images are generated and saved, rather than attempted to be displayed.

sophie22 commented 1 year ago

various tests are failing as expected. Will update the hazenlib test so that CLI args align with what is now expected to be provided for the task and will look into the relaxometry unit tests too.

sophie22 commented 1 year ago

I am unable to run the T2 calculation on my laptop due to a Bus error, it is not expected to have been introduced with these code changes. - will investigate further

github-actions[bot] commented 1 year ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   HazenTask.py25388%32–34
   __init__.py541769%125–133, 145, 179–181, 184–186, 193–196, 207
   exceptions.py21481%17–21
   relaxometry.py3108573%251–269, 626, 684–686, 740, 788–810, 828–843, 1153–1156, 1165–1171, 1203–1247
   utils.py1894377%61, 65, 75, 80, 117, 124–129, 140, 143–150, 170–172, 190–192, 211–213, 222, 227, 233, 284, 287, 295–300, 303, 346, 355, 371
hazenlib/tasks
   acr_geometric_accuracy.py1465662%38–75, 179–195, 209–233
   acr_ghosting.py1174363%33–55, 93–95, 125–127, 163–196
   acr_slice_position.py1555465%53–76, 154, 215–260
   acr_slice_thickness.py1546458%40–62, 188–243
   acr_snr.py1416256%34–78, 103, 172–182, 215–228, 261–274
   acr_spatial_resolution.py2447470%66–90, 169, 212, 225–234, 323–378
   acr_uniformity.py903363%34–56, 123–140
   ghosting.py1525365%18–35, 50, 112–113, 117, 127–128, 154–156, 173–175, 221–259
   relaxometry.py770%1–11
   slice_position.py1172380%28, 37–38, 49, 103–104, 130, 210, 217–234
   slice_width.py3575385%34–37, 41, 109, 168–188, 453, 458–459, 465, 470, 532–533, 782–823
   snr.py1666760%51, 68–73, 167–185, 200–209, 227–237, 264–274, 279–289, 320–333, 338–346, 375–388
   snr_map.py104199%291
   spatial_resolution.py2474582%36–39, 43, 64, 149, 208, 334–370
   uniformity.py792075%42–45, 51, 93–94, 101, 135–149
TOTAL289180772% 

Tests Skipped Failures Errors Time
215 0 :zzz: 0 :x: 0 :fire: 3m 24s :stopwatch: