GSTT-CSC / hazen

Quality assurance framework for Magnetic Resonance Imaging
https://github.com/GSTT-CSC/hazen
Apache License 2.0
22 stars 12 forks source link

Incompatible python versions #412

Closed RebeccaThornley closed 7 months ago

RebeccaThornley commented 9 months ago

Description A few members of our team have freshly downloaded hazen recently using versions of python higher than 3.9. Using the pip install with these later versions of python results in an old version of hazen being downloaded (1.0.2). Both 3.11 and 3.12 have been tested.

To Reproduce Following pip install guidance:

python3 -m venv hazen-venv [or python3.11(12) -m venv hazen-venv] source hazen-venv/bin/activate pip install hazen

Expected behavior Currently instructions say that python version of 3.9 or higher is required. Therefore expected v3.11 or v.12 to be compatible.

Screenshots

Screenshot 2024-02-15 at 09 50 22

Desktop:

Additional context This isn't a big problem as the easy work around is to download python3.9 and install hazen with this. But if it is the case that 3.9 is a requirement could the instructions be updated to be more clear?

sophie22 commented 9 months ago

I managed to install the latest hazen version (v1.3.2) after modifying the pypi config file which had a requirement for Python version to be below 3.11. This manually installed version produced results for all MagNet and ACR datasets and tasks in my test folders, so I don't see why this Python version restriction was hard coded.

Will ask around in the development team and if there are no objections, I will update the Python version requirement to be above 3.9, which should support latest Python versions. I envision this to become available in the next release, planned for sometime in May.