Mibi/dev/surface edges - Githubissues

GSharker / G-Shark

G-Shark is a free and open-source geometry library designed for computational designers and software developers in the Architecture, Engineering, and Construction (AEC) industry.

https://gsharker.github.io/G-Shark/

MIT License

215 stars 37 forks source link

Mibi/dev/surface edges #380

Closed sonomirco closed 1 year ago

sonomirco commented 3 years ago

What type of PR is this? (check all applicable)

[ ] ♻️ Refactor
[X] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR added the method to extract the edges of the surface. At the moment is limited only to surfaces of 4 edges.

Related Tickets & Documents

This PR closes #124

Added tests?

[X] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[X] 📓 docs
[ ] 🙅 no documentation needed

d3ssy commented 1 year ago

can this be merged?

sonomirco commented 1 year ago

Yes.