GSharker / G-Shark

G-Shark is a free and open-source geometry library designed for computational designers and software developers in the Architecture, Engineering, and Construction (AEC) industry.
https://gsharker.github.io/G-Shark/
MIT License
212 stars 36 forks source link

Plane bug #382

Closed NishantC5 closed 2 years ago

NishantC5 commented 2 years ago

What type of PR is this? (check all applicable)

Description

This PR fixes the bug that was present in one of the Plane's constructors which took in a point and two direction vectors. The constructor now computes the orthogonal vectors which would define the X-axis and the Y-axis of the plane considering the first input direction to be the X-axis. Although there were already three test cases that that referenced this constructor, another test case is added which is dedicated for this particular constructor.

Related Tickets & Documents

This PR Fixes #377

Added tests?

Added to documentation?