search

GSharker / G-Shark

G-Shark is a free and open-source geometry library designed for computational designers and software developers in the Architecture, Engineering, and Construction (AEC) industry.
https://gsharker.github.io/G-Shark/
MIT License
215 stars 37 forks source link

Adds Mesh implementation #397

Closed AlanRynne closed 1 year ago

AlanRynne commented 1 year ago

DRAFT:

sonomirco commented 1 year ago

Hey @AlanRynne, could we start to review this PR?

d3ssy commented 1 year ago

Hey @AlanRynne, could we start to review this PR?

Reviewed with Alan this AM based on comments on previous PR. Fresh commits coming in soon and then ready to merge! 🚀

AlanRynne commented 1 year ago

Hi all! Sorry for the delay on this I've been a bit busy lately! I'm planning on wrapping this up between today and tomorrow and leave it up to you guys to review for any improvements! 👍🏻

d3ssy commented 1 year ago

Noice. 🤘

On Mon, Jan 16, 2023, 2:55 PM Alan Rynne @.***> wrote:

Hi all! Sorry for the delay on this I've been a bit busy lately! I'm planning on wrapping this up between today and tomorrow and leave it up to you guys to review for any improvements! 👍🏻

— Reply to this email directly, view it on GitHub https://github.com/GSharker/G-Shark/pull/397#issuecomment-1384540467, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPXUISKJTU56WRVROWYGI3WSWYUTANCNFSM6AAAAAATRVMNRY . You are receiving this because you commented.Message ID: @.***>

d3ssy commented 1 year ago

@AlanRynne is this good to go?!

sonomirco commented 1 year ago

@AlanRynne, any updates on this branch?

AlanRynne commented 1 year ago

Hey @sonomirco, @d3ssy! I would have sworn I had pinged you guys here to review this... but I seemed to have left my message unsent 🙇🏼‍♂️

I think this one is ready to go unless you have any particular opinions on any part of the code ;)