GSharker / G-Shark

G-Shark is a free and open-source geometry library designed for computational designers and software developers in the Architecture, Engineering, and Construction (AEC) industry.
https://gsharker.github.io/G-Shark/
MIT License
215 stars 37 forks source link

Dev/nich/point equals null bug #418

Closed NishantChandrashekhar closed 1 year ago

NishantChandrashekhar commented 1 year ago

What type of PR is this? (check all applicable)

Description

Previously, the equals and the == operator of the Point3 didn't handle the null input case, ie if one (or both) of the inputs were null then the function would throw an error. I have modified the function to return false when either of the inputs is null or if both the inputs are null (the second scenario is what I have observed when I compared two string variables having null values).

This PR Fixes #417 .

Added tests?

Added to documentation?

d3ssy commented 1 year ago

Thanks @NishantChandrashekhar! Looks good to go