search

GT-WebDev-GameLogs / gamelogs

A social, review platform for video games
0 stars 0 forks source link

Added Navbar #19

Closed Techo10n closed 1 month ago

Techo10n commented 1 month ago

Added a new components folder with an initial navbar implementation (only has the navbar before signing in implemented)

Updated a few small things in index.css for styling.

TimothySung1 commented 1 month ago

Nice. Again, similar suggestions from last time to make the sections into separate components as well. As good practice for frontend changes, add some screenshots to the pull request just to give a good idea of what's changed. Regardless, I ran it locally and it works well.

One bug I noticed was that on my laptop, the sliding cards slide over the Latest News section, and past the gray filter (that's I believe intended to darken the sliding cards or the background behind the title text).

There are some nitpicks (which I can't really complain, since I'm terrible at frontend), e.g. section headers could pop out more, notably distinct sections, make text not change the mouse pointer into the bar thing, but I think these changes can be merged. Just keep the minor bug and other feedback in mind. Nicely done!