GTAmodding / GTAIV-Issues-List

10 stars 0 forks source link

Tuning of Specular reflections/highlights on vehicles #158

Open Maadi5 opened 5 months ago

Maadi5 commented 5 months ago

On direct comparison between console version and PC (reference: Cousins Bellic), there's very evidently much high specular highlights along the edges of vehicle bodies to external light sources (especially at night), giving the vehicles a much more realistic look (on consoles) that don't seem to match up on fusionfix yet.

valentyn-l commented 5 months ago

On direct comparison between console version and PC (reference: Cousins Bellic), there's very evidently much high specular highlights along the edges of vehicle bodies to external light sources (especially at night), giving the vehicles a much more realistic look (on consoles) that don't seem to match up on fusionfix yet.

Could you show us your direct comparisons?

Maadi5 commented 4 months ago

On direct comparison between console version and PC (reference: Cousins Bellic), there's very evidently much high specular highlights along the edges of vehicle bodies to external light sources (especially at night), giving the vehicles a much more realistic look (on consoles) that don't seem to match up on fusionfix yet.

Could you show us your direct comparisons?

Yes, attaching examples: Console: Image 17-06-24 at 10 42 AM PC with FusionFIx: sodapdf-converted

Console: Image 17-06-24 at 10 45 AM PC with FusionFix: GTAIV 2024-06-17 10-45-25-52

As you can see, those external light sources (white lights above the car in both cases) are barely reflected by the car. Upon more inspection, you can barely notice evidence of it in the vehicle reflecitons. They are very diffused and mild. Only the sky light and other geometries are reflected prominently.

Edit: It seems like light sources that aren't the sun, seem to be almost non-existent on vehicles - Whereas, each local light source pops beautifully on the console vehicle reflections.

Maadi5 commented 4 months ago

Any thoughts/questions? Cheers!

valentyn-l commented 4 months ago

Image 17-06-24 at 10 42 AM PC with FusionFIx: sodapdf-converted

Console: Image 17-06-24 at 10 45 AM PC with FusionFix: GTAIV 2024-06-17 10-45-25-52

As you can see, those external light sources (white lights above the car in both cases) are barely reflected by the car. Upon more inspection, you can barely notice evidence of it in the vehicle reflecitons. They are very diffused and mild. Only the sky light and other geometries are reflected prominently.

Edit: It seems like light sources that aren't the sun, seem to be almost non-existent on vehicles - Whereas, each local light source pops beautifully on the console vehicle reflections.

This issue will be addressed in the next FF release. Reflection intensity has been reverted to the original setting equivalent to the console setting and will also be tweakable by the user.

Please note that console gamma in the next FF release will closely resembles the PS3 version and not the Xbox 360 version, thus altering how highlights are perceived. This was an internal decision and is subject to change.

Maadi5 commented 4 months ago

Image 17-06-24 at 10 42 AM PC with FusionFIx: sodapdf-converted Console: Image 17-06-24 at 10 45 AM PC with FusionFix: GTAIV 2024-06-17 10-45-25-52 As you can see, those external light sources (white lights above the car in both cases) are barely reflected by the car. Upon more inspection, you can barely notice evidence of it in the vehicle reflecitons. They are very diffused and mild. Only the sky light and other geometries are reflected prominently. Edit: It seems like light sources that aren't the sun, seem to be almost non-existent on vehicles - Whereas, each local light source pops beautifully on the console vehicle reflections.

This issue will be addressed in the next FF release. Reflection intensity has been reverted to the original setting equivalent to the console setting and will also be tweakable by the user.

Please note that console gamma in the next FF release will closely resembles the PS3 version and not the Xbox 360 version, thus altering how highlights are perceived. This was an internal decision and is subject to change.

Awesome! I must say, this community is doing truly amazing work. I just wanted to thank all of you for it!

RecklessGlue540 commented 4 months ago

Please note that console gamma in the next FF release will closely resembles the PS3 version and not the Xbox 360 version

Great to hear it's getting tuned further. Any plans to apply it to the UI pass as well? As that's how it is on consoles...

RecklessGlue540 commented 2 months ago

This can get a resolved label

The shaders have been tuned so that coronas look stronger in specular reflections such as on vehicles, ground etc, looking pretty identical to how consoles do it.

Console Gamma on the other hand remains pretty much the same now. The aforementioned tweaks were reverted recently, because it turns out the "Contrast" slider in the Display menu actually controls gamma, making tweaks in the code unnecessary. Xbox 360 also turns out to have a bug about that contrast slider, being one tick to the left even though it's centered, so on PC I assume tweaking it one tick to the left will bring back the 3.0 intensity, if desired. https://github.com/Parallellines0451/GTAIV.EFLC.FusionShaders/commit/e41e07970a43d846f263ddd6fc5c7966dd5daf70