Cleanup(move images): Images to Contentful

GTBitsOfGood / bog-component-library

A reusable, easily readable, easily integrated, and widely used component library for Bits of Good.

https://bog-component-library.netlify.app/

1 stars 0 forks source link

Cleanup(move images): Images to Contentful #103

Closed tawsifkamal closed 2 years ago

tawsifkamal commented 2 years ago

Description

Closes 74

Moves homepage images from the Github repo to the BoG contentful CMS.

Type of change

🔁 Chore/Cleanup

How to Test

Usually this is just running the yarn command and checking the component on the storybook UI

Checklist

[ ] A Contentful CMS
[ ] API permissions set up for the homepage
[ ] ENV variables to abstract the API keys
[ ] Delete images from repo

netlify[bot] commented 2 years ago

✔️ Deploy Preview for bog-component-library canceled.

🔨 Explore the source changes: caeb59390631a66b8048f5652b4c3aad381d5e76

🔍 Inspect the deploy log: https://app.netlify.com/sites/bog-component-library/deploys/620bf0522cb0f80007719873

therealsharath commented 2 years ago

Assign the PR to me as a reviewer + I think the build is failing because you have a node package missing 🤔

therealsharath commented 2 years ago

Also did you use npm install instead of yarn install?

therealsharath commented 2 years ago

Right now the .env file only exists on your local system so we need to find a way to create this file when someone clones the repo + add the env variable to the Netlify deployment env. Send me the env file by email temporarily so I can figure out how to get these issues resolved 🙂

therealsharath commented 2 years ago

Overall, everything else looks good to me! Honestly a really good job on handling such a complex change on your first ever ticket @tawsifkamal 🎉 😄