GTBitsOfGood / bog-component-library

A reusable, easily readable, easily integrated, and widely used component library for Bits of Good.
https://bog-component-library.netlify.app/
1 stars 0 forks source link

Jl/fix radio button #139

Closed jade-law closed 2 years ago

jade-law commented 2 years ago

Description

Closes #93

Made RadioGroup which uses RadioButton. Fixed isDisabled not working (will have to refresh storybook window when changing it in the params on storybook though)

Type of change

🤕 Bug Fix

How to Test

yarn storybook -> check out component Can also run Jest tests

Checklist

netlify[bot] commented 2 years ago

✔️ Deploy Preview for bog-component-library canceled.

🔨 Explore the source changes: eebfca389c50fda487425e123445e212eb06e7fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/bog-component-library/deploys/6215f3857162960008cd3ed9

jade-law commented 2 years ago

JEST test note: I'm failing a test for the Alert button instead

therealsharath commented 2 years ago

LGTM! 🚢 it

alysonlam commented 2 years ago

Looks good to me! Only thing is the outline looks smaller than 1 px, but it might be my display/how it's rendering for me.