GTBitsOfGood / bog-component-library

A reusable, easily readable, easily integrated, and widely used component library for Bits of Good.
https://bog-component-library.netlify.app/
1 stars 0 forks source link

feature(scrolling table of contents ): scrolling navigation implemented #153

Closed whymarlene closed 2 years ago

whymarlene commented 2 years ago

Description

Closes #148

Make a scrolling component for use on our homepage website.

Type of change

🆕 Feature

How to Test

yarn storybook

Checklist

Progress

netlify[bot] commented 2 years ago

Deploy Preview for bog-component-library ready!

Name Link
Latest commit e88387d77632d0be0737455834b2318e32e14784
Latest deploy log https://app.netlify.com/sites/bog-component-library/deploys/6254f55650e5f7000936ffc3
Deploy Preview https://deploy-preview-153--bog-component-library.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

whymarlene commented 2 years ago

I have to add theming but the essential parts of the navigation are there. I will also add tests. Let me know if it needs more customization.

For now, I am planning on:

Open Question: Should there be sub-sections? If so, what would that look like?(Maybe a future feature?)

whymarlene commented 2 years ago

Update: I couldn't really think of any other tests other than the one I made.

Lmk if there is anything I need to change!

therealsharath commented 2 years ago

I'd rename the component to just ScrollNavigation instead of the long name it has rn.