Add vertical tab list component

GTBitsOfGood / bog-component-library

A reusable, easily readable, easily integrated, and widely used component library for Bits of Good.

https://bog-component-library.netlify.app/

1 stars 0 forks source link

Add vertical tab list component #155

Closed jade-law closed 2 years ago

jade-law commented 2 years ago

Description

Closes #149

Added component story and testing

Type of change

🆕 Feature

How to Test

yarn storybook -> Vertical Tab List yarn test

Checklist

[ ] Code follows design and style guidelines
[ ] Code is commented with doc blocks
[ ] Latest code has been rebased from base branch (usually develop)
[ ] Commits follow guidelines (concise, squashed, etc)
[ ] Github issues have been linked in relevant commits
[ ] Relevant reviewers (EM) have been assigned to this PR

netlify[bot] commented 2 years ago

Deploy Preview for bog-component-library canceled.

Name	Link
Latest commit	2c26a250f8a29acb8a5c1cd8bd0e06e847bc26d9
Latest deploy log	https://app.netlify.com/sites/bog-component-library/deploys/624ca006eb9afc00089af14a

alysonlam commented 2 years ago

Everything looks good! The hard coded color will need to be changed once Sharath adds some missing colors. The only thing I would ask is if it's possible to change the number of menu items, edit the links they go to, and then change the width of the component.

therealsharath commented 2 years ago

@alysonlam a dev should be able to do all the things you mentioned, however, I don't think it's practical to implement that functionality in storybook. (It would take too long and possibly require another sprint or so because of the way storybook works)