GTBitsOfGood / bog-component-library

A reusable, easily readable, easily integrated, and widely used component library for Bits of Good.
https://bog-component-library.netlify.app/
1 stars 0 forks source link

Added sizes to buttons #61

Closed therealsharath closed 2 years ago

therealsharath commented 3 years ago

Description

Closes https://github.com/GTBitsOfGood/bog-component-library/issues/39

This change adds the size functionality, which lets the user toggle the size of the button.

UI Changes

Large Button

image

Medium Button

image

Small Button

image

Type of change

🆕 Feature

How to Test

Clone the repo, then run yarn storybook once the yarn packages are installed.

Checklist

alysonlam commented 3 years ago

Heyo, there's a few things:

  1. the font (Visby CF) should be extra bold
  2. the padding looks a bit off for each of the sizes
  3. I'm adding ss of the dimensions, keep in mind that each font has a specific height and line height image This is also added to the button page in the Figma if you want to look back at it
therealsharath commented 2 years ago

@alysonlam I changed the line height to match the Figma docs and the padding to match the commented ss. Any other changes?

therealsharath commented 2 years ago

Large Button

image

Medium Button

image

Small Button

image

Idk how useful these are but I can demo these if that helps! @alysonlam