Open ashispati opened 5 years ago
Folder: src/prediction_models/experiments/pitched_instrument_regression/
testFileStatus.m
: this might be useful for data preprocessing but doesn't belong in this folderfixSamplingRateInFiles.m
: this might be useful for data preprocessing but doesn't belong in this folder main.m
: Not a function but we are not using it any of our resultscreateTrainingDataPitchedInstruments.m
: only used in main.m
evaluatePerformancePitchedInstrument.m
: only used in main.m
stackFolds.m
: doesn't belong in this foldernfoldPartition.m
: doesn't belong in this folderAdditionally there are a few feature extraction functions in this folder named as extract...Features.m
which should ideally be in src/prediction_models/feature_extraction/
folder
Folder: src/prediction_models/experiments/snare_etude_regression/
featureNormalization2.m
Folder: src/prediction_models/preprocessing/pitch/
wavelet.m
wavePitch.m
yinAlgo.m
The above files are used in estimatePitch.m
but these algorithms have not been used in any of our experiments so far.
Might be a good idea to also move all pYin related files / scripts to a separate sub-folder.intervalCents.m
: also available in src/prediction_models/preprocessing/pitch/quantization/
Folder: src/prediction_models/preprocessing/score_alignment/
ToolSimpleDtw.m
: also available in src/prediction_models/feature_extraction/StandardFeatures/
Folder: src/prediction_models/scanning/
checkDurSegments.m
checkNumSegments.m
copySongsToFolder.m
findAnnotationOutliers.m
findMissingAnnotations.m
scanSegmentFilepaths.m
All the above are not used anywhere else in the repo. They are useful in finding files with missing annotations. But scanning folder might not be the best location for them though. Folder: src/prediction_models/visualizations/
README
This folder only contains this file and nothing else. Might consider removing it altogether and create it later if neededFolder: src/prediction_models/fix_broken_tracks/
fixBrokenFiles.py
: used to fix some of the bad audio files
This is a useful Python script but I am thinking if we should have this in this code repository !!Folder: src/prediction_models/feature_extraction/
ampDev.m
extractFeaturesPitchedInstruments.m
: This has copies in the experiments folder alsoFeatureSpectralFlatness.m
FeatureSpectralKurtosis.m
FeatureSpectralMfccs.m
FeatureSpectralRolloff.m
FeatureSpectralSkewness.m
FeatureSpectralTonalPowerRatio.m
ToolMfccFb
All above from 3. to 9. are duplicated in src/prediction_models/feature_extraction/StandardFeatures/
GenerateDctMatrix.m
: should be in the StandardFeatures
folderFolder: src/prediction_models/feature_extraction/MFCC
This contains the labrosa MFCC extraction code and is being used in the timbreDev.m
feature extraction. Not sure why we are not using Alexander's MFCC extraction code for this though.
Folder: src/prediction_models/feature_extraction/ScoreBasedDesignedFeatures/
HistInsertDeleteNotes.m
IncorrectNotes.m
TempoHistFeat.m
Folder: src/prediction_models/feature_extraction/StandardFeatures/
ComputeBeatHisto.m
ComputeKey.m
ComputeNoveltyFunction.m
ComputePitch.m
FeatureSpectralCrestFactor.m
FeatureSpectralDecrease.m
FeatureSpectralPitchChroma.m
FeatureSpectralSlope.m
FeatureSpectralSpread.m
FeatureTimeAcfCoeff.m
FeatureTimeMaxAcf.m
FeatureTimePeakEnvelope.m
FeatureTimePredictivityRatio.m
FeatureTimeStd.m
NoveltyFlux.m
NoveltyHainsworth.m
NoveltyLaroche.m
PitchSpectralAcf.m
PitchSpectralHps.m
PitchTimeAcf.m
PitchTimeAmdf.m
PitchTimeAuditory.m
PitchTimeZeroCrossings.m
TestGammaToneFb.m
ToolFreq2Bark.m
ToolFreq2Mel.m
ToolFreq2Midi.m
ToolGammaToneFb.m
ToolMidi2Freq.m
The feature_extraction
folder can be reorganized into 3 sub-folders for baseline
, designed
and score_based_designed
features
The preprocessing/pitch
folder can be reorganized into 2 sub-folders acf
and pyin
I am thinking of the following plan to do this:
fixSamplingRateInFiles.m
in thesrc/prediction_models/experiments/pitched_instrument_regression/
folder). A simple exercise which would help identify such code is if each of us picks a folder make a list of the functions (NOT scripts) inside that folder are not being used. I have done it for the sub-folders ofsrc/prediction_models/experiments/
folder as an example and others can follow the same for the other folders and generate these lists as comments on this issue thread (as shown below). You may also add any other comments as you see fit.