GTMEGA / EndlessIDs

A rewrite of NotEnoughIDs for 1.7.10 with even more IDs!
https://falsepattern.com/mc
Other
29 stars 6 forks source link

[Bug]: mod file can't be rename, or else crash #140

Open XLin0mu opened 10 months ago

XLin0mu commented 10 months ago

OS

Windows

GPU

NVIDIA

Modpack (Optional)

many, such as ExtraUtil or Thaumcraft and so on

Game log

ExtraUtil's: ExUtillatest.log

and Thaumcraft's: TClatest.log

Description

When I change mod file's name, even just a ASCLL letter, it get crashed when chunks generating. Actually it's not only happend on some particular mods, but for reference, log's above. btw there's one detail, tc's crash is after world created a little time, but exutil's was at world creating progress.

FalsePattern commented 10 months ago

EndlessIDs uses the filenames to detect what mods are present for mixins, which are used to inject code into other mods to make them compatible with EndlessIDs. This cannot be done through the regular forge APIs, because forge is not yet loaded fully at that point.

Solution: Do not rename mod files

XLin0mu commented 10 months ago

fine.

XLin0mu commented 10 months ago

Wait, how about puting it into config file as an optional item? So modpack makers can rename mod's filename as they wish. Sorry for the request but it's really kind of meaningful to some non-English country's users.

FalsePattern commented 10 months ago

I figured out a solution that doesn't require filenames. It's a bit complicated but i think i can upload the fix later this week.