GTMEGA / EndlessIDs

A rewrite of NotEnoughIDs for 1.7.10 with even more IDs!
https://falsepattern.com/mc
Other
29 stars 6 forks source link

[Bug]: Crash with ASJCORE ON Server #142

Closed quentin452 closed 3 months ago

quentin452 commented 10 months ago

OS

Linux/BSD

GPU

NVIDIA

Modpack (Optional)

no modpack

Game log

https://mega.nz/file/etM2TaiY#Yltk8KW5c9EyCRDUc2uYBYC_2Jv0Eyn8vSlLSHRvqLU

Description

The crash appear only on server with asjcore and endless ids installed

i think the crash come from this class : https://raw.githubusercontent.com/FalsePattern/EndlessIDs/master/src/main/java/com/falsepattern/endlessids/asm/IETransformer.java

probably related to #130

note : the issue start to appaer since endlessids-mc1.7.10-1.4.0-alpha0001+biometestvanilla

quentin452 commented 10 months ago

The issue with asjcore dissapear by commenting this line ,but make crashes with another mods (triggered by a crash like an incompat but it shouldn't) so i guess the crash is caused with asjcore by ChunkProviderSuperPatcher class: Capture d’écran_2023-08-23_14-35-39

FalsePattern commented 10 months ago

Found the issue, i had some missing try/catch blocks in my transformer code, and some classes just do not like being transformed on serverside, because they have weird half-client half-server methods. I'll turn this into a regular warning in the next hotfix, but it might permanently corrupt worlds if it turns out transforming said class is actually important, so make sure to create backups frequently.

quentin452 commented 10 months ago

ok thx

brandyyn commented 4 months ago

Found the issue, i had some missing try/catch blocks in my transformer code, and some classes just do not like being transformed on serverside, because they have weird half-client half-server methods. I'll turn this into a regular warning in the next hotfix, but it might permanently corrupt worlds if it turns out transforming said class is actually important, so make sure to create backups frequently.

was this ever pushed? someone was complaining about it on the alfheim server that they crash when trying to start their mc server with alfheim and eids, i haven't tried to run it on a server yet but i also run both mods.

brandyyn commented 3 months ago

@FalsePattern

FalsePattern commented 3 months ago

Fixed in 1.5 beta 3