GTMEGA / EndlessIDs

A rewrite of NotEnoughIDs for 1.7.10 with even more IDs!
https://falsepattern.com/mc
Other
30 stars 7 forks source link

[Compatibility Request]: BiomeTweaker and Climate Control #185

Closed Sunconure11 closed 2 weeks ago

Sunconure11 commented 3 months ago

Other mod's name

BiomeTweaker and Climate Control

Other mod's homepage

Read text

Other mod's license

Other open source license (please specify in the description)

Game log

crash-2024-06-20_09.58.40-server.txt

Description

https://www.curseforge.com/minecraft/mc-mods/climate-control-geographicraft

https://www.curseforge.com/minecraft/mc-mods/biometweaker

The two mods use two differing licenses.

Sunconure11 commented 3 months ago

The issue is that both mods act really weird in regards to mods that assign more IDs on this version of MC.

Sunconure11 commented 3 months ago

crash-2024-06-20_10.33.19-client.txt

Extra Biomes XL also keeps trying to assign itself to your placeholder biome.

Sunconure11 commented 3 months ago

This, in turn, screws up generation with stuff like RTG because it then places placeholder biomes in the form of mushroom island biomes. BoP is notably affected by this.

https://www.curseforge.com/minecraft/mc-mods/biomes-o-plenty

https://www.curseforge.com/minecraft/mc-mods/realistic-terrain-generation

https://www.curseforge.com/minecraft/mc-mods/alternate-terrain-generation

brandyyn commented 3 months ago

This, in turn, screws up generation with stuff like RTG because it then places placeholder biomes in the form of mushroom island biomes. BoP is notably affected by this.

https://www.curseforge.com/minecraft/mc-mods/biomes-o-plenty

https://www.curseforge.com/minecraft/mc-mods/realistic-terrain-generation

https://www.curseforge.com/minecraft/mc-mods/alternate-terrain-generation

this isn't a bug with endlessids, its a bug with bop, any default world that you havent selected as a biomesop world type will spawn mushroom biomes everywhere, the only way to fix this is to disable mushroom biomes in the bop config. it's a bug with bop, not endlessids.

but if i do recall correctly, climatecontrol doesnt work with endlessids, but i'll need to check to make sure

brandyyn commented 3 months ago

my attempt at creating a world with climatecontrol in my pack with endlessids: fml-client-latest.log crash-2024-06-23_00.44.28-server.txt

Sunconure11 commented 2 months ago

Out of curiosity, I decided to try this with the Gregtech New Horizons fork of Climate Control. Same error.

Sunconure11 commented 2 months ago

My reasoning for trying their fork is that some mods they maintain contain various fixes for stuff that never got such as players moved to newer versions of MC.

Sunconure11 commented 2 months ago

I've also noticed that only vanilla, Extra Biomes XL, and Thaumcraft biomes show up.

Sunconure11 commented 2 months ago

image

Sunconure11 commented 1 month ago

Requesting a possible look-over by two other devs that have committed recently, @Houstonruss and @Darek505

Sunconure11 commented 1 month ago

https://github.com/GTMEGA/EndlessIDs/issues/189

Related issue

FalsePattern commented 1 month ago

Should be fixed in 1.5.3

Sunconure11 commented 1 month ago

BiomeTweaker may need a patch.

Sunconure11 commented 1 month ago

latest.log

Sunconure11 commented 1 month ago

Issue seems to be solved, though I am waiting on another mod to fix an issue it has that is preventing me from verifying.

Sunconure11 commented 1 month ago

The crash with the other mod seemed to let up with updates to some existing mods.

When attempting to create a Realistic world with RTG though, I got this crash: https://pastebin.com/A6y7gc6i

brandyyn commented 1 month ago

Same issue here https://github.com/GTMEGA/EndlessIDs/issues/189#issuecomment-2294515113

FalsePattern commented 2 weeks ago

It should be fixed in the latest nightly, you can grab it here: https://github.com/GTMEGA/EndlessIDs/actions/runs/10851105588/artifacts/1930260469 the mod jar is inside the zip file

FalsePattern commented 2 weeks ago

This bug is now tracked in #189