GTNewHorizons / CodeChickenLib

GNU Lesser General Public License v2.1
11 stars 9 forks source link

"API of the renderer is broken" #15

Closed GedeonGrays closed 3 months ago

GedeonGrays commented 3 months ago

Hello o/

I apologize for linking to another issues-tracker, but this will make it easier to explain the nature of the current issue.

The problem with RPLE: https://github.com/GTMEGA/RPLE/issues/8

Caedis commented 3 months ago

False changed the CCL API in their fork and then used it in RPLE

Disregard

mitchej123 commented 3 months ago

LIkely fixed by https://github.com/GTNewHorizons/CodeChickenLib/pull/16

GedeonGrays commented 3 months ago

Looks like the problem is not solved. Line 53 of the crash report and some other lines have changed a bit, otherwise the crash is the same. crash-2024-07-01_22.31.08-client.txt

mitchej123 commented 3 months ago

The latest crash is a bug on RPLE's side.

Caused by: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: @Shadow method brightness in mixins.rple.json:client.codechickenlib.CCRenderStateMixin from mod rple was not located in the target class codechicken.lib.render.CCRenderState. Using refmap mixins.rple.refmap.json

This line - doesn't exist in upstream CCL and was added to the public API by the gtmega fork here.