GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.03k stars 315 forks source link

Disassembler gives microprocessors instead of electronic circuits #12425

Closed 704009905 closed 1 year ago

704009905 commented 1 year ago

Your GTNH Discord Username

Hexadecimal#1191

Your Pack Version

2.2.8

Your Server

Self-hosted private server

Type of Server

Vanilla Forge

Your Expectation

In quest "Gimme My Stuff Back!" (Tier 1 - LV) it reads: "If there's an oredicted item like a circuit, it should return the least valuable one." I suppose electronic circuit is the least valuable of LV-tier circuit(oredict:circuitBasic).

The Reality

But the disassembler gives microprocessors when disassembling LV machines. Tested with LV and MV disassembler.

Your Proposal

Gimme My Least Valuables Back!

Final Checklist

BritishCynic commented 1 year ago

There is no reason why, if you're OK with the Electronic Circuit, to be unhappy over receiving a Microprocessor back. They're effectively the same for crafting.

704009905 commented 1 year ago

There is no reason why, if you're OK with the Electronic Circuit, to be unhappy over receiving a Microprocessor back. They're effectively the same for crafting.

But it is different from what the quest describes, we should change the disassembling or quest content. Personally, I'm OK with microprocessors :D but I'm worried about this behavior gives imbalanced results e.g. advanced circuits can craft something but basic ones don't (not sure if this situation exists).

vovaksenov commented 1 year ago

The idea of returning the worst circuit comes from how we want this circuit to be least upgradeable. For example there should be no way for people to convert quantum mainframes to a crystalprocessor zpm circuit which is upgradeable to UV crystal mainframe. Microprocessors on the other hand are not upgradeable by design, so in some way, they are the least valuable, so if they are returned there is no problem. They can be converted to the electronic circuit through the configuration circuit, but that is another story.

704009905 commented 1 year ago

The idea of returning the worst circuit comes from how we want this circuit to be least upgradeable. For example there should be no way for people to convert quantum mainframes to a crystalprocessor zpm circuit which is upgradeable to UV crystal mainframe. Microprocessors on the other hand are not upgradeable by design, so in some way, they are the least valuable, so if they are returned there is no problem. They can be converted to the electronic circuit through the configuration circuit, but that is another story.

I didn't think of this, so in some sense microprocessors can be considered the least valuable and it's OK? I'm on HV so I don't know about the higher tiers. Just tried to disassemble ZPM disassembler and it gives quantum mainframes, seems works as intended.