Nanosuit Boots of the traveller incorrectly boost speed while flying

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery

https://www.gtnewhorizons.com/

Other

943 stars 294 forks source link

Nanosuit Boots of the traveller incorrectly boost speed while flying #12864

Open chochem opened 1 year ago

chochem commented 1 year ago

Your GTNH Discord Username

chochom#0271

Your Pack Version

2.3.0

Your Server

Java Version

Java 19

Type of Server

Single Player

Your Expectation

Things should be the same as before we went to GraviNeo. The boots should not affect flying speed.

The Reality

They give a roughly 4x speed increase.

I do not know if other boots are broken too.

Your Proposal

Change things back to the old behaviour.

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

BritishCynic commented 1 year ago

For me, the speed increase over regular nanosuit boots while in the air feels like a decent QoL upgrade

chochem commented 1 year ago

it also defeats the point of upgrading to anything else. And makes no sense whatsoever, your boots should not decide your flying speed.

This is just a bug.

King65868 commented 1 year ago

Boots of the voidwalker speed up flying speed, so there is some sense in this

vovaksenov commented 1 year ago

I feel like this could be an EMT issue and related to my #12863 Only a possibility, nothing certain.

DragonStorm25 commented 1 year ago

The same thing happens with Quantum Boots of the Traveller

chochem commented 1 year ago

tested now, it is caused by https://github.com/GTNewHorizons/Electro-Magic-Tools/pull/53 which was just supposed to change jumping. @TimeConqueror any ideas? I dont want to revert your entire PR if it can be avoided. I dont care how the jumping works tbh.

TimeConqueror commented 1 year ago

Original Traveller's Boots give you extra movement boost while jumping. So the improved Traveller's Boots should also give you at least the same value. Before that commit it was giving you less movement boost while jumping comparing to orginal Thaumcraft's one. This is against the design of 'craft to upgrade' and discourages people once they crafted it. So if it needs a fix, it definitely shouldn't be done in a way of reverting the item to its previous mechanics.

chochem commented 1 year ago

ok so no clue? then we might have to revert.

chochem commented 1 year ago

timeconqueror looked into slightly more on discord and suggested this could be fixed on the gravisuite side

https://discord.com/channels/181078474394566657/603348502637969419/1090731166409162762

chochem commented 1 year ago

it looks like other forms of flight are affected too, e.g. copterpack. so a fix on the gravisuits side makes no sense. This has to either be fixed/reverted here or be declared a feature (which is what mitch wants without even trying it)

chochem commented 6 months ago

reopen as alastor mentioned he wants to look it into last week.