Robes of the Stratosphere causes a memory leak

[clifward]

Your GTNH Discord Username

Clifward#1363

Your Pack Version

2.3.0

Your Server

Private Server

Java Version

Java 19

Type of Server

Vanilla Forge

Your Expectation

I should be able to watch a player equipped with the "Robes of the Stratosphere" without having a huge increase in memory consumption.

The Reality

When a player look in the direction of another player equipped with the "Robes of the Stratosphere" , it causes the memory consumption of Java to skyrocket until the OOM.

(the other player equipped with the robes is hidden behind the aluminium tank wall, and the RAM usage increases)

(when the other player is not rendered)

Each increase of RAM usage shown in the screenshot happens exactly while rendering the player equipped with the robes.

This behavior has been reproduced with :

• Java 8, 17, 19
• Windows, Linux, MacOS
• when the robes is not on a player, but on an armor stand.

Your Proposal

Fix the memory leak.

Final Checklist

• [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• [X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[El-Basurero]

I ran into the same issue as well while wearing the robes. I tested on Java 8, 20, and 17 on windows 10. I play on a private server which was fine, but I would get a memory leak client side and crash after about an hour due to running out of RAM.

Let me know if there are any logs or anything I can provide that would be helpful.

[Lyfts]

Can confirm that this memoy leak is present on 2.3.2 aswell. Memory instantly starts spiking when you put on the robe and stops shortly after removing it.

[MineCracked]

Happening on 2.4.0 as well. Java 17,20 same effect. Java 8 unknown. Running mp server. Anytime a player wears it, or is in the presence of another player wearing it, this happens. Confusingly, this only happens to other players. I don't think I have seen the effect personally, just my teammate.

[mitchej123]

If you could run visualvm memory profiling and figure out what's being leaked that'd be helpful. A heapdump before, and after, and then diffing the two would be useful. #mod-dev would be a good place to chat about this, a few people have done it before.