GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
876 stars 273 forks source link

Blood altar automation can void blood orbs #14401

Open kumquat-ir opened 10 months ago

kumquat-ir commented 10 months ago

Your GTNH Discord Username

thelastkumquat

Your Pack Version

2.3.4

Your Server

private server, reproduced on SP

Java Version

Java 8

Type of Server

Single Player

Your Expectation

Attempted to insert a blood orb into the blood altar with automation after extracting slates from the altar with automation

The Reality

It voided the blood orb. Simple reproduction case in video. Note the "Altar progress:" and "Crafting:" lines in waila. Sometimes it doesn't void the orb and instead ends up with a MAX_INT% altar progress shown.

https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/assets/66188216/8f6ed111-74d9-40f1-9f96-a16dc2edc019

Your Proposal

Properly check for the validity of recipes when items are piped in and out

Final Checklist

joegnis commented 5 months ago

Thank you for reporting. I thought it was OC's fault. I am using OC to put orb back after crafting. It does not happen very often but it has already eaten two orbs. It is also not limited to eating blood orbs. I tried putting a cobblestone to altar after a crafting, and it still ate it. I am playing version 2.5.1.