GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
968 stars 298 forks source link

Thaumcraft infusion nbt detection #14494

Closed hacatu closed 2 months ago

hacatu commented 1 year ago

Your GTNH Discord Username

hacatu

Your Pack Version

2.4.0

Your Server

SP

Java Version

Java 17

Type of Server

None

Your Expectation

Items with empty vs no nbt should be treated the same

The Reality

Consider the infusion for the adept essentia diffusion cell. One of the components is a space coolant cell. If you enable tooltips with /mt tooltips, all versions of this item will show the nbt as {}.

However, if you use a version of this item freshly crafted or cheated in from nei, it will work, but if you use a version from AE, it will not work. But what is the difference? MT tooltips reveal they even have the same nbt data!

In fact, the difference is that the space coolant cell that has been tainted by AE has NO nbt tag, NOT an empty nbt tag as the tooltip shows. /mt hand gives the correct info. This is pretty strange and misleading behavior on MT's part, but ultimately this seems to be a thaumcraft bug because the nbt checking should absolutely not accept items with empty nbt but not items with no nbt

Your Proposal

-

Final Checklist

hacatu commented 1 year ago

Edit: you can also use a name remover to break your space coolant cells, if you don't want to pass them through AE. Both result in the empty nbt tag being removed