Trade-O-Mat recipie disable

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery

https://www.gtnewhorizons.com/

Other

947 stars 296 forks source link

Trade-O-Mat recipie disable #14595

Closed SMSum closed 11 months ago

SMSum commented 11 months ago

Your GTNH Discord Username

summer_g123

Your Pack Version

2.4.0

Your Proposal

The trade-o-mat shouldn't have a recipe as you can set it up to trade literally anything for anything. EX, dirt for titanium. I know the button for the infinite stock is OP only but still probably shouldn't be around to begin with. javaw_2023-09-25_23-57-15 javaw_2023-09-26_00-02-52

Your Goal

Removal of a useless and broken block.

Your Vision

Cleaning up loose ends + exploits.

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this change please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
[X] I understand this change request may not attract enough attention and thus not be implemented.
[X] I understand this change request may be rejected due to other community members think it's inappropriate.
[X] I believe this feature would make the pack better.

TechnicianLP commented 11 months ago

This block is intended to facilitate trade between players (i give you 1x titanium if you give me 1x dirt). Unless you enable infinity mode with op perms, (basically equivalent to a creative vending upgrade from storage drawers) items have to be stocked by the "selling" player. I dont see an exploit here. Players with OP-Permissions will always be able to give themselves any item.

SMSum commented 11 months ago

Fair, just wasn't sure if it was really used in that way or not, considering you can't even break the block without vajra + it currently seems to lack a texture when placed. Seemed like a depreciated item that wasn't meant to be around still.

Dream-Master commented 11 months ago

as long you cant get items out not belongs to you its not taht bad. If someone want to exchange Dirt for Titanium his/her fault. If the block drop items and you get it illigal when you break the block i will disbale it.

Rika-TH commented 11 months ago

Fair, just wasn't sure if it was really used in that way or not, considering you can't even break the block without vajra + it currently seems to lack a texture when placed. Seemed like a depreciated item that wasn't meant to be around still.

Sounds like at the very least it being unbreakable would need fixing assuming you don't just mean needs vajra to be picked up? (Guess same idea could almost be applied to warding which is fine, issue here would be a player placing it doesn't know this)

SMSum commented 11 months ago

Fair, just wasn't sure if it was really used in that way or not, considering you can't even break the block without vajra + it currently seems to lack a texture when placed. Seemed like a depreciated item that wasn't meant to be around still.

Sounds like at the very least it being unbreakable would need fixing assuming you don't just mean needs vajra to be picked up? (Guess same idea could almost be applied to warding which is fine, issue here would be a player placing it doesn't know this)

Yea, its vajra silk touch only (so same as warding), it doesnt drop anything when broken. But at least on my client (2.4.0) it has no texture as well. javaw_2023-09-26_18-01-58

Glease commented 11 months ago

Closing the ticket now given the above conversation suggest there is nothing wrong with the block