GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
942 stars 294 forks source link

Energy Detector Cover works wrongly on a LSC with Ultimate Capacitors #14809

Open Quaerere-Git opened 10 months ago

Quaerere-Git commented 10 months ago

Your GTNH Discord Username

No response

Your Pack Version

2.4.0

Your Server

SP

Java Version

Java 19

Type of Server

None

Your Expectation

According to the configuration of the energy detector cover, when the energy stored in the LSC reached the threshold, the lamp beneath should turn off just like the case without ultimate capacitor. 2023-11-01_21 01 51 2023-11-01_20 56 17 https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/assets/42565872/791466f4-ee47-441b-b6f9-1bed97cad837 (In this case threshold is set to 12TEU)

The Reality

The lamp didn't turn off even the energy stored reached the threshold set (in this case 10TEU), meaning that the cover still give out redstone signal when it shouldn't. https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/assets/42565872/49378803-b029-49f8-8425-09de62046743 Actually even when energy stored in both the wireless network and the LSC reached the threshold set, the energy detector cover still gives out redstone signal.

Your Proposal

fix

Final Checklist

bombcar commented 10 months ago

Can you try it with a value below 2,147,483,647? Maybe hard to discharge it that much, perhaps try in a creative world

Quaerere-Git commented 10 months ago

Can you try it with a value below 2,147,483,647? Maybe hard to discharge it that much, perhaps try in a creative world

2023-11-01_22 11 36 2023-11-01_22 11 45 I'm sure it's not the problem of int limit

kevin00036 commented 10 months ago

Can confirm that I had this same issue (2.4.0), our setup with LSC + Energy Detector Cover worked pretty well until we upgraded it with a UHV capacitor. Before the upgrade, we already had capacities and thresholds larger than the 32-bit integer limit (UV capacitor can store 600B EU) and it still worked well, perhaps it has to do with exceeding the 64-bit integer limit instead? (UHV cap is right at the limit, we also have a few IV caps to fill the space so the total capacity exceeds that)

Ubus99 commented 4 months ago

Same issue here, will this get fixed in 2.6?

chochem commented 4 months ago

in the mean time, you can use it without threshold and then use your preferred way to threshold limit the redstone line.

Ubus99 commented 4 months ago

in the mean time, you can use it without threshold and then use your preferred way to threshold limit the redstone line.

Wait, if you enter 0 it works analog? That explains a lot about my debugging.