GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
992 stars 301 forks source link

Microblocks #14921

Open aeksae opened 11 months ago

aeksae commented 11 months ago

Your GTNH Discord Username

aeksae

Your Pack Version

2.4.0

Your Server

SP

Java Version

Java 8

Type of Server

None

Your Expectation

https://www.twitch.tv/videos/1984186039 Z-Tone Myst and Cubits (chisel) half cuts turned in to Blood Rune Slabs https://cdn.discordapp.com/attachments/948587114369548319/1176853528938041404/image.png?ex=65706142&is=655dec42&hm=7e17c2f9df68e5d784f8a259bf8ce2278a2360842e7093ad4b4db0b8d66b24ae&

The Reality

above

Your Proposal

fix if you can

Final Checklist

Pxx500 commented 11 months ago

image first link doesn't work

aeksae commented 11 months ago

https://www.twitch.tv/videos/1984186039

AbdielKavash commented 10 months ago

I am experiencing this too; on 2.4.1, Java 19 singleplayer. This used to be a reinforced glass window.

javaw_Iio2pgT5Ga

Unfortunately I do not know what causes this, and I can not reproduce this consistently. However the issue is sporadically repeating every once in a while, on isolated structures (one window like above gets changed, other identical windows are unaffected).

I have seen different "source" blocks change, but the resulting block is always Blood Rune.

The change is not just visual, if something like slabs or panels change, I can harvest them and craft them back into functional blood runes. (I guess enabling a potential unintended Blood Magic progression skip exploit if one can reproduce this consistently?)

boubou19 commented 10 months ago

are all those corrupted microblocks in the same region file?

AbdielKavash commented 10 months ago

They are all in the same region file, but not all microblocks in the same region file get corrupted at the same time. When it happens the problem is very localized; this window is the only one that got changed in my entire base.

Unfortunately I don't remember off the top of my head if it is affecting all blocks in one chunk at the same time (the window in the picture is contained in one chunk).

AbdielKavash commented 10 months ago

Well this is new :concern:

Sordfish42 commented 5 months ago

2024-04-29_22 09 55 I'm recurrently having this problem. My base's nether brick and glowstone Microblocks often get replaced by blood rune slabs. They often are replaced in long lines or patterns, almost like its a spreading infection

I've had this through multiple versions now. I've only just noticed this above set after updating to 2.6, but could have occured in the previous version

dvdmandt commented 4 months ago

So microblocks work by having a "material" registered. These are often based on the unlocalized name of the block instead of the block id or whatever. There appears to have been a change to move over to block IDs at some points, and there's some form of remapping code here: https://github.com/GTNewHorizons/ForgeMultipart/blob/master/src/main/scala/codechicken/microblock/BlockMicroMaterial.scala#L169-L172

Perhaps that's the issue? The move to switch over to block ids (I assume that's what Block.blockRegistry.getNameForObject(block) gets?) happened like 10 years ago, but I've found that the unlocalized name is what is stored in the block for many block types.

@Sordfish42 could you run /nbtedit while looking at one of the changed blocks, expand all + icons and screenshot the results, then do the same with one of the unchanged blocks?

DarkYuan commented 4 months ago

@dvdmandt

could you run /nbtedit while looking at one of the changed blocks, expand all + icons and screenshot the results, then do the same with one of the unchanged blocks?

I'd like to help with this too, but I couldn't find a command for /nbtedit, though I got the /mt blockinfo of them here:


[Client thread/INFO]: [CHAT] Block ID: ForgeMultipart:block
[Client thread/INFO]: [CHAT] Meta value: 0
[Client thread/INFO]: [CHAT] Tile entity data: {x: 1337, parts: [{shape: 16 as byte, material: "minecraft:stone", id: "mcr_face"}], y: 65, z: 319, id: "savedMultipart"}
[Client thread/INFO]: [CHAT] Block ID: ForgeMultipart:block
[Client thread/INFO]: [CHAT] Meta value: 0
[Client thread/INFO]: [CHAT] Tile entity data: {x: 1338, parts: [{shape: 20 as byte, material: "AWWayofTime:AlchemicalWizardrybloodRune", id: "mcr_face"}], y: 64, z: 319, id: "savedMultipart"}
Sordfish42 commented 4 months ago

@dvdmandt

Thank you for getting back to me. Here are the results. First is the changed block, second is unchanged. 2024-06-09_19 20 30 2024-06-09_19 20 54

@DarkYuan Nbtedit is a seperate mod you can donwload and add to your modlist https://www.curseforge.com/minecraft/mc-mods/forge-nbtedit-for-1-7-10