GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
907 stars 284 forks source link

RecipeMapBackend.checkCollision() may have a problem; it occupies 20% of the startup time #15446

Open wohaopa opened 6 months ago

wohaopa commented 6 months ago

Your GTNH Discord Username

No response

Your Pack Version

2.5.1

Your Proposal

Perhaps there could be a cache or a more efficient solution to improve the current approach. Personally, I feel it shouldn't be this inefficient.

38fc97299e7de8ecf9e08ace901ab0ec 747e4eeed09ac974b08e3f7b446d583b

Your Goal

Optimize the recipe loading system for GT, such as implementing a caching system, to improve the startup speed of GTNH.

Your Vision

I hope the startup speed of GTNH can be faster so that I can launch it anytime I want to play, just like the quick startup of the "All the Fabric" modpack.

Final Checklist

wohaopa commented 6 months ago

https://github.com/GTNewHorizons/GT5-Unofficial/blob/356bd9473ed21913e8793a06c796b853928b27ef/src/main/java/gregtech/api/recipe/RecipeMapBackend.java#L314

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days