Thaumic parts give wierd amount of mods

[imTheSupremeOne]

Your GTNH Discord Username

imthesupremeone

Your Pack Version

2.5.1

Your Server

Private

Java Version

Java 21

Type of Server

Don't know

Your Expectation

The same parts either don't stack or stack in a logical way

The Reality

x4 thaumic parts give +2 mods on a fresh axe x3 thaumic parts give +1 mod x2 thaumiv parts give 0 mod

We have x2 Thaum parts but 0 modifiers :

The x3 Thaum parts give 1 mod :

And x4 gives 2 :

The thing that I can't exchange another thaumic part for netherrack may hint onto the reason of this bug :

Your Proposal

Make it intuitive; also the thing that I can't exchange back parts on 2-mod thaumium to 1-mod may hints that there is some bug and modifiers are wasted...

Final Checklist

• [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• [X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[leumasme]

TinkersConstruct code to handle thaumium: https://github.com/GTNewHorizons/TinkersConstruct/blob/2a6cd9ffe9140974c92a8aa1b69a5eb39b558051/src/main/java/tconstruct/tools/TinkerToolEvents.java#L138-L155

• Each thaum part gives 0.5 Modifiers, rounded up
• Exception for tool types that have only 2 parts: Each Thaum gives one modifier
• Thus for Lumber Axe:
  • 1 Piece Thaum: 1 Modifier
  • 2 Pieces Thaum: 1 Modifier
  • 3 Pieces Thaum: 2 Modifiers
  • 4 Pieces Thaum: 2 Modifiers

IguanaTweaksTConstruct code to handle replacing thaumium parts: https://github.com/GTNewHorizons/IguanaTweaksTConstruct/blob/bcc8d670becb2715ee9d3a119307ac86648e2108/src/main/java/iguanaman/iguanatweakstconstruct/replacing/ReplacementLogic.java#L281-L308

• Removing Paper and Thaum parts is treated as exactly the same
• Removes 1 Modifier per removed Thaum part

The Part Replacement logic for Thaumium is wrong (but that seems to be the only issue here, all your other described issues seem to stem from this and not knowing how it is supposed to work).

Repro:

• Make a Lumber Axe out of 3 Parts Netherrack, 1 Part Thaum (Axe A)
• Axe A has 1 modifier (0.5 * 1 rounded up = 1)
• Make a Lumber Axe out of 2 Parts Netherrack, 2 Parts Thaum (Axe B)
• Axe B has 1 modifier (0.5 * 2 rounded up = 1)
• Replace a Thaum part of Axe B with Netherrack
• Axe B should now be identical to Axe A - Instead, it has 0 Modifiers instead of 1

[leumasme]

Keep open, this is still an issue (nightly 2024-09-24)

https://github.com/user-attachments/assets/538646a3-8857-4591-8d9c-a5e40d879736