Multiple Thaumic Bases blocks incorrectly labeled as infusion stabilizers

budak7273 commented 7 months ago

Your GTNH Discord Username

robb4

Your Pack Version

2.5.1

Your Server

Private Server

Java Version

Java 17

Type of Server

Vanilla Forge

Your Expectation

Build with "ancient iron slabs" from Thaumic Bases and have it count as an infusion stabilizer according to the Arcane Abacus, since the tooltip says it is.

The Reality

The blocks don't actually offer any infusion stability.

Also doesn't work with double slabs.

Compare with this setup using valid infusion stabilizers:

Your Proposal

Resolve the inaccurate tooltip by either making the following blocks actually stabilizers, or removing the tooltip.

The following blocks claim they are stabilizers in the tooltip, but aren't actually stabilizers according to the Arcane Abacus:

thaumicbases:genericSlab:4 (Ancient Diamond Slab)
thaumicbases:genericSlab:5 (Ancient Gold Slab)
thaumicbases:genericSlab:6 (Ancient Iron Slab)
thaumicbases:genericSlab_full:4 (Ancient Diamond Slab) [double slab]
thaumicbases:genericSlab_full:5 (Ancient Gold Slab) [double slab]
thaumicbases:genericSlab_full:6 (Ancient Iron Slab) [double slab]

Also, the following blocks do not currently have the stabilizer tooltip, and do not count as stabilizers. I propose that their behavior should match their slab variants.

thaumicbases:oldIron (Ancient Iron Block)
thaumicbases:oldGold (Ancient Gold Block)
thaumicbases:oldDiamond (Ancient Diamond Block)

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

chochem commented 7 months ago

on the first proposal: ancient iron/diamond/gold slabs dont look craftable to me.

for the second: ancient iron/gold/diamond block are obtained by chiselling the normal ones. Which makes sense for purely cosmetic blocks, but means they should not be made into stabilizers.

budak7273 commented 7 months ago

Oops, I wasn't aware they were uncraftable, I don't have all the thaum research unlocked in this world so I assumed it was gated by something I didn't have access to and/or there wasn't NEI support for the recipe. The questbook says in multiple places to not trust NEI recipes for thaum.

Is there a reason they're not craftable? FTB wiki claims their recipe would be a not-very-greg 3 blocks to six slabs crafting table recipe. I can see why that particular recipe was removed.

I should have clarified: at the end of the day I don't really care if they are stabilizers or not - I just don't want them to have the "I am a stabilizer" tool-tip if they aren't stabilizers, since I search "infusion stabilizer" to see my options (is there another way I should be using instead)? It's still a bug, and the bug is, "Multiple Thaumic Bases blocks incorrectly labeled as infusion stabilizers"

budak7273 commented 7 months ago

Looking into this further has revealed more oddities.

Ancient Iron/Gold/Diamond Blocks can be chiseled as you mentioned, but you can also craft them in the Arcane Workbench with an entropy crystal block. An astute NEI-er would notice and never use the arcane workbench recipe.

The following blocks (and their slab variants) work as infusion stabilizers and have valid slab recipes in the Cutting Machine. They can't be chiseled, they only have the Arcane Workbench crafting recipe.

Ancient Cobblestone
Ancient Mossy Cobblestone

Ancient Lapis Lazuli Blocks and slabs work as stabilizers. Their slabs don't have a recipe but you can get one slab from the L.E.S.U. Upgrade - EV Tier quest.

It's not really clear to me if this family of blocks is intended to be decoration, stabilizer, or both. If iron/gold/diamond are intended as purely decorative, then why do the cobbles and lapis get a different treatment?

Seems like there are more decisions to make here. Should I split this into multiple issues with some as suggestions and some as bug reports?

chochem commented 7 months ago

that quest reward looks very out of place for sure.

AdolMors commented 7 months ago

I saw abacus has its own implementation of checking. I am more curious about if this logic is identical to Thaumcraft's stability checking so the abacus can be fully trusted.

Graymare commented 6 months ago

Agree that if said blocks are not valid infusion altar stabilizers, it would be preferable to remove the tooltip that says they may be usable. Gold and Iron blocks are probably a little too easy to get with just Chisel, should at least have an Arcane Worktable requirement / Thaumcraft ingredient like Ancient Cobble does.

budak7273 commented 6 months ago

As it stands, I think mob heads are the cheapest infusion stabilizer (just need a mob farm), followed by ancient cobblestone (1 entropy crystal cluster for 8).

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

github-actions[bot] commented 4 weeks ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

budak7273 commented 4 weeks ago

Pretty sure this is still an issue (commenting to prevent auto close)

GTNewHorizons / GT-New-Horizons-Modpack