GTNewHorizons / GT-New-Horizons-Modpack

A big progressive questing modpack for Minecraft 1.7.10 balanced around the mod GregTech.
https://www.gtnewhorizons.com/
Other
1.01k stars 307 forks source link

Ore generation not consistent on server instances #15626

Closed Sethfire closed 8 months ago

Sethfire commented 8 months ago

Your GTNH Discord Username

Sethfire

Your Pack Version

2.5.1

Your Server

Local private server

Java Version

Java 17

Type of Server

Don't know

Your Expectation

As far as I'm aware, ore generation is only dependent on the world seed, and is fixed upon world generation. I've confirmed this behavior in singleplayer by generating multiple worlds with the same seed, and confirming that the same ore veins are present at the same location.

However, this appears to not be the case for servers. Upon each server restart, the "RNG" for the ore generation appears to reset and cause some ore veins to change from one type of ore to another. This can be observed by either re-generating the world with the same seed or loading the world from a backup where the chunks have not been generated.

Here is an example of ore veins changing (Open these images up in a new tab and switch between the tabs to see the difference): image image

This wouldn't really be that big of an issue on it's own, and it may even be intended. However, the issue occurs when an ore vein is half-generated, the server is restarted, and then the other half gets generated.

This is what the ore veins here are supposed to look like, when I prospect this area on a singleplayer server: image

The Reality

When I generate the chunks up to the red line, move east, and then generate the remaining chunks, glitched ore veins appear. I've highlighted in red the glitched ore veins. image

To reproduce:

  1. Generate a world using the server pack download
  2. Log in to the server, move a bit away from spawn to some ungenerated chunks.
  3. Log off, restart the server
  4. Log back in, and then move to ungenerated chunks nearby.
  5. Check the ore veins with the visual prospector

Your Proposal

I'm not sure if the ore generation is intended to be randomized on servers, but please make it fixed like in singleplayer if this is the case.

Final Checklist

Sethfire commented 8 months ago

Redoing ticket as I've noticed it occurs in singleplayer as well