Crop Manager Not Applying Secondary Effects (Water/Weed-Ex)

rbraunm commented 5 months ago

Your GTNH Discord Username

Toshiro4269

Your Pack Version

2.5.1 *2/25 nightly build for GT, GTNHLib, and GT++

Your Server

private server

Java Version

Java 21

Type of Server

None

Your Expectation

Crop manager applies weed-ex, water, and fertilizer to empty crop sticks or crossed cropsticks if it is enabled on the machine. If it does eventually apply it takes so long many of the crop sticks had weeds when I checked on the farm.

The Reality

Setup: HV crop manager with an LV gas turbine, as pictured.

Crop manager applies the weed-ex and water properly to all crop sticks with plants but seems to inconsistently apply to crop sticks and crop sticks that are crossed. I have waited up to 10 minutes monitoring a pair of crossed crop sticks without any application of either. After a weed appears or after a plant breeding occurs, however, water and weed-ex applied properly. Water and weed-ex get reapplied properly after that.

In the attached picture the red x sticks all have 0 for water and weed-ex while the green ones had weeds or bad crossbreeds that were removed and thus it now has Weed-ex and water.

Just to confirm I planted some more crop sticks and saw the same behavior; the last few images.

It may be a way to save those secondary materials since no actual crop is there and hypothetically you don't need the extra stats, but Weed-Ex especially is necessary where there is no crop. Water and fertilizer probably can remain unapplied as long as it's applied before the plant that starts growing checks for its nutrient requirements, otherwise this may result in losing crops the first time a cross-breed occurs on a fresh farm in a non-optimal biome.

I am playing, as noted in the version section, on the nightly from 2/25 that addresses the similar bug reported here: https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/15369 I only replaced the following 3 files from that build:

Your Proposal

Ensure empty crop sticks and crossed crop sticks have Weed-ex applied. Also ensure water and fertilizer are applied to crossed crop sticks.

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

Krydax commented 2 months ago

bumping this. I have observed weird janky behavior with these as well.

bunducdragos commented 1 month ago

also crop manager stops watering if it's inventory is full. if the plant was mature for long enough to hit 0 water and the water was needed for the crop to survive, it wil die after it is harvested, crop manager will not water the plant in time (from some) after harvest

another bug is that it will void items, if there is no more space left it will stop harvesting but if there is 1 slot free and let's say your field was fully grown it will fill that slot but the rest of the items will be voided

GTNewHorizons / GT-New-Horizons-Modpack