GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
986 stars 299 forks source link

Apply Kuba's pattern optimization to the rest interface which can hold patterns. #15766

Open miaowwwwww opened 7 months ago

miaowwwwww commented 7 months ago

Your GTNH Discord Username

MIAOW246

Your Pack Version

2.6.0 build 3.9.0

Your Proposal

add support to the rest 3 items that can hold patterns. "dual-interface", "item crib", "item&fluid crib" (I did comment under the original pr but no reply yet, I guess a suggestion is better.) update: dual is done, cribs left

Your Goal

to make the pattern optimization function work well as a whole. I love the function.

Your Vision

make GTNH greater.

Final Checklist

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

kstvr32 commented 1 month ago

This seems to have been implemented for AE2FC by Kuba in GTNewHorizons/AE2FluidCraft-Rework#200.

I'm going to take a look at adding support for CRIBs

kstvr32 commented 1 month ago

After some testing it looks like this does work for CRIBs. I think this issue can be closed.

miaowwwwww commented 1 month ago

After some testing it looks like this does work for CRIBs. I think this issue can be closed.

image image it does not have this 2 buttons at the left(nightly 618)

kstvr32 commented 1 month ago

CRIBs are supported for the pattern optimization matrix (done when crafting).

I can add support to disable optimization and double/half in the CRIB itself.