GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
991 stars 300 forks source link

Tinkers Tools cannot be renamed after initial craft #16035

Open imTheSupremeOne opened 6 months ago

imTheSupremeOne commented 6 months ago

Your GTNH Discord Username

imthesupremeone

Your Pack Version

2.5.1

Your Server

Private

Java Version

Java 21

Type of Server

Don't know

Your Expectation

Tool should be renamed after going through Tool Forge : image

The Reality

Nothing happens. image

As you can see the font is already italic and it's because I've tried battling it before and failed but was too lazy to report it here. Even if tool at 100% durability; I also tried mb to enforce it by doing repair + rename at the same time but it stays with the name it was crafted.

If tool wasn't given any custom name at first assembly it can not be renamed either : image

Renaming tool with anvil isn't perfect too. It changes it's font to italic and technically the Tinker Name still stays on the tool : image

Your Proposal

Fix Tool Forge Renaming.

Prob look at anvil renaming too as it's clearly isn't fully supported to work at Tinker's tools.

Final Checklist

RealSilverMoon commented 6 months ago

public static boolean canRename(NBTTagCompound tags, ItemStack tool) { This means a tool can only be renamed once. Seems that this logic was decided at the very beginning. I would say it's time to change that—give renaming permissions to players doesn't hurt anything.