GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
948 stars 296 forks source link

Advanced memory card voids all patterns in me dual p2p #16416

Open nyanmaid opened 3 months ago

nyanmaid commented 3 months ago

Your GTNH Discord Username

No response

Your Pack Version

2.5.1

Your Server

SP

Java Version

Java 17

Type of Server

Single Player

Your Expectation

place two p2p dual interface on same ae network, fill one of them with patterns duplicate above setup so a network has 4 p2p dual interfaces use advanced memory card to repeatedly switch all outputs to input, all input to output, or just randomly click buttons on advanced memory card GUI. expectation: patterns should drop on the ground.

The Reality

patterns got void.

Your Proposal

advanced memory card will void patterns. I saw a similar issue on old version but it says fixed. However this issue still exist in 2.5.1.

Final Checklist

hacatu commented 4 days ago

Confirmed in 2.6.1.

The dual interface p2p will also void patterns (and upgrade cards including pattern capacity cards, and reset all settings) if you simply unlink it in the advanced memory card. This is really unfortunate because it often stops multiplexing if you add new "output p2ps" with the advanced card, which might then prompt you to try unlinking and relinking it.

It would be cool if interfaces p2ps took some qol from cribus

Generally speaking, the interface "p2ps" are in a really weird spot. The "output p2ps" show in the interface terminal and can have their settings (blocking mode, optimize patterns, show in interface terminal, etc) individually changed. This obviously doesn't make sense. Also, they can only be flat interfaces even though full block interfaces are sometimes more useful.

Contrast this to crafting input busses/buffers, where the crafting input slaves DON'T show in the pattern terminal, you CAN'T make them void patterns, they can be a full block at least for the purpose of passing channels, right clicking a linked output just opens the gui for the corresponding input, they automatically distribute patterns without having to enable blocking mode on each one, etc.

Quick and dirty fix for affected players

Finally, there are a few ways to avoid this happening (yank all patterns and upgrades from the input p2p every single time you want to reconfigure the links, use a basic memory card, or just use regular interfaces and manually copy patterns).

However, if you just do the obvious thing and try to modify them with the advanced memory card, you might encounter this but, so a fix for it besides re-encoding all the patterns is to 1) re link and reconfigure without patterns (easy because all your patterns got voided) 2) load the latest backup and bookmark all the patterns 3) cheat in the patterns from your bookmarks Not only does this prevent you from having to re-create patterns that probably have random multiples and dummy items, but it allows you to let your crafts continue without restarting them.