Tier 3 Cargo Rocket does not land well and crashes upon take off

[boldviking]

Your GTNH Discord Username

BoldViking

Your Pack Version

2.6.1

Your Server

private server

Java Version

Java 8

Type of Server

Single Player

Your Expectation

Expectation:

Automate rockets with rocket controllers without the rockets exploding.

The Reality

I am using rockets to transport ore from remote worlds to my main hub world. Currently the setup is a route between ross128 and earth.

The setup is using the launch controller to automate the rockets. The launch criteria are "launch on cargo full" for ross128 and "launch on cargo empty" for earth. There is no fancy redstone logic or any other fancy elements. This is the most basic setup.

When launching the rocket automatically to ross128 from earth, the rocket will land miss aligned. See here:

The rocket is considered to be on the pad for loading/unloading purposes. Once the automatic rocket launch is initiated the rocket will actually slowly descend into the ground and will explode on impact once it hits the ground. See here:

There is a small excavated area underneath the rocket. I had hoped that the rocket would still just launch though the remaining launch pad. Yet that seems to cause the rocket to explode.

Do note, that the rockets will teleport correctly if I am riding inside of them. This issue only happens when the rockets fly without a player inside of them.

Edit: Lowering the launchpad by 2 blocks to match the spawn location does not fix the issue.

Edit2: Yeah it seems it aligns with where the player would stand when they would be standing on the pad. See this image for reference. When I enter the rocket I basically stand on the pad inside the rocket.

Your Proposal

It seems to me that when teleporting the rocket over to its destination the offset for the height is incorrect. This value probably needs to be adjusted for each of the respective rocket tiers.

Alternatively, fix cargo rockets as they currently do not accept any rocket fuel and can not be used.

Final Checklist

• [X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
• [X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
• [X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

[boldviking]

We tested it on stream and noticed that we get the same height miss-match for tier 2 rockets as well.

We also dug through the code during the stream and we got closer to a possible answer.

Here is a list of observations:

• The teleport miss-match only seems to be happening for non overworld teleports. We tested it for the moon as well.

• Tier 2 rockets have the exact same offset as tier 3 rockets. Standing in a rocket will make the player sink into the ground a bit, as tier 2 rockets are shorter.

  We suspect that the bug is originating from any of these files:

https://github.com/GTNewHorizons/Galacticraft/tree/9dccc6faaec5e66e6623a10857f43f7d37b67c85/src/main/java/micdoodle8/mods/galacticraft/core/dimension

Note that there is a special overworld teleport as well as special teleports for moons and such. This could explain why overworld teleports work, but off world teleports do not work.