GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
881 stars 275 forks source link

Mage's Mace Only Adds Damage Once #16597

Open Ruling-0 opened 5 days ago

Ruling-0 commented 5 days ago

Your GTNH Discord Username

ruling_

Your Pack Version

2.6.1

Your Server

private server

Java Version

Java 21

Type of Server

Vanilla Forge

Your Expectation

Applying the focus Mage's Mace to a staff, removing it, then re-applying it should mean the staff has the empowered damage (in this case, 60x2=120).

image

The Reality

Applying the focus, removing it, and then applying it again will not add the damage. Stated otherwise - the focus, if ever removed from a staff, means that specific staff can never make use of the focus again. Bookmarking the staff in this state, deleting it, and spawning one from the bookmark (which preserves item data) will again not properly use the focus. Only spawning a fresh version of the staff will the focus work properly, until it is removed. Name Remover does not fix it. Aside from the screenshotted staff, I have also tested on the creative one (Orichalcum Studded Cosmic Neutronium Staff).

image

Your Proposal

I suspect there's an anti-bug bit of code designed to prevent being able to rapidly swap the focus to boost damage. However, it's currently not working, and it means a staff must be dedicated to Mage's Mace, which is not ideal, and if the focus is ever accidentally removed a new staff must be made (or spawned in). This bug should thus be fixed so the focus can be removed and reapplied as all other focuses can be.

Final Checklist