GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
969 stars 298 forks source link

Many methods of silk touch not dropping GT ore blocks #16679

Open serenibyss opened 3 months ago

serenibyss commented 3 months ago

Your GTNH Discord Username

serenibyss

Your Pack Version

Nightly 2024-06-08+510

Your Server

private server

Java Version

Java 17

Type of Server

Vanilla Forge

Your Expectation

Silk touch or similar mechanics should all be able to drop ore blocks as their block form rather than raw ore.

The Reality

Many different methods of silk touch cannot drop an ore block. From my testing: Can drop:

Cannot drop:

Your Proposal

All methods of silk touch should work to drop an ore block.

Final Checklist

Caedis commented 3 months ago

I think https://github.com/GTNewHorizons/GT5-Unofficial/blob/master/src/main/java/gregtech/common/blocks/GT_Block_Ores_Abstract.java#L194-L196 needs to be set to true, but I am not sure what else that might change.

Ethryan commented 3 months ago

I think https://github.com/GTNewHorizons/GT5-Unofficial/blob/master/src/main/java/gregtech/common/blocks/GT_Block_Ores_Abstract.java#L194-L196 needs to be set to true, but I am not sure what else that might change.

Hmm, There was a reason that I didn't touch it. I think it had to do with the small ores becoming Silk Touchable if I did.

Caedis commented 3 months ago

small ores should be fine to be silk touchable with the same logic