Assemblyline Process: recipe have non-unique circuits

GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery

https://www.gtnewhorizons.com/

Other

994 stars 303 forks source link

Assemblyline Process: recipe have non-unique circuits #16839

Open slprime opened 3 months ago

slprime commented 3 months ago

Your GTNH Discord Username

SLPrime

Your Pack Version

nightly 550

Your Server

Java Version

Java 17

Type of Server

None

Your Expectation

I expect to see a unique set of items.

The Reality

Have:

Your Proposal

PositionedStack have been unique. At the moment I found a similar problem only In Assemblyline Process

P.S. (items in tooltip is new function which I'm working on)

Final Checklist

[X] I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
[X] I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

chochem commented 3 months ago

i am not sure I understand. is this a ticket about your own wip feature?

slprime commented 3 months ago

i am not sure I understand. is this a ticket about your own wip feature?

no, I found recipes that have duplicates items in PositionedStack.items. this one breaks shift+scroll, preventing you from scrolling through the entire list. my feature only shows this problem

slprime commented 3 months ago

We need to correct the recipes for the Assemblyline Process so that the circuits do not have duplicates

slprime commented 3 months ago

I haven’t worked on GT and recipes before, and I can’t fix it myself

P.S. sorry english is not my main language

Ya9yu commented 3 months ago

i am not sure I understand. is this a ticket about your own wip feature?

I can confirm that when we tested a new feature with a list in the tooltip, SLPrime discovered a problem due to which the shift + scroll in the assembly line recipe was broken

chochem commented 3 months ago

hmm well scrolling seems to work just fine for me (without this feature). The recipes in GT also look fine.

slprime commented 3 months ago

in what version of NEI/GTNH you tested?

chochem commented 3 months ago

nightly 562 with NotEnoughItems-2.6.18-GTNH-pre

Ya9yu commented 3 months ago

A little outside experience Several of my friends in GTH have this problem and they don’t even suspect its significance. For example, one friend, when shift + scrolling thecircuits of the ZPM, the crystal processors are completely ignored, no matter how hard he scroll them I have a similar situation, before SLPrime found a way to solve this problem for me, my biomainframes were completely ignored when shift + scrolling the UV microcircuits Other people have a problem that the circuits are spinning in some strange order, but in fact they have a clear order from the stage of the technical process, but the PositionedStack must be unique for this to work

dimazha commented 3 months ago

seems to work just fine

In recipes with ZPM circuits I can't roll quantum ZPM circuit. I tried to roll in both directions

chochem commented 3 months ago

hmm, there is indeed some weird stuff with the order, but I do get all myself:

curious.

slprime commented 3 months ago

in 562 + gregtech-5.09.48.102.jar + gtnhintergalactic-1.4.5.jar (java 21)

https://github.com/user-attachments/assets/d8a405a2-4aaf-490a-8301-6e9dd9c64f4c

after reload

https://github.com/user-attachments/assets/bed23fe2-e695-48a9-9c04-d1415e96407e

It depends on how the modpack was loaded

chochem commented 3 months ago

I see. the recipes themselves are fine, so maybe something in the recipemap handling or the specific NEI handling. AL has some special code for recipe map handling with some extra code for handling oredicts and alternative items. Probably something in there.

Since the scrolling part is inconsistent I guess its easier to debug once your feature is a thing.

miaowwwwww commented 3 months ago

a little addition to the pattern editing situation: when i scroll, i usually don't get 1 or 2 circuit to show, so I scroll very fast(not 1 by 1) and let it stop on some random circuit, this way it is possible to roll the missing circuit.