GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
970 stars 298 forks source link

Crop Manager Tooltip Wording #16886

Closed SkilledAlpaca closed 3 weeks ago

SkilledAlpaca commented 2 months ago

Your GTNH Discord Username

SkilledAlpaca

Your Pack Version

2.6.1

Your Proposal

Crop Manager Tooltip says "Can harvest 1 block level above and below itself." Per the wiki, several members of the Discord and my own testing. This tooltip is not correct and should be changed from 1 to 2.

Can harvest 2 blocks level above and below itself

image

Your Goal

Clearer information regarding the device and how to best utilize it.

Your Vision

Same as goal.

Final Checklist

leumasme commented 3 weeks ago

Agree / this should be type:bug, not suggestion. The "Can harvest below/above itself" part of the tooltip was already updated, but the box height was not.

Crop manager tooltip says "Radius: N blocks each side (Nx3xN)" where N depends on tier. image https://github.com/GTNewHorizons/GT5-Unofficial/blob/daaebf5e39946a2197c750acb8cd345fe48d2e0b/src/main/java/gtPlusPlus/xmod/gregtech/common/tileentities/machines/basic/MTECropHarvestor.java#L518

The 3 is incorrect here; it should say 5 as the crop manager will harvest up to 2 blocks above and below itself, thus forming a box with the height of 5.

If the height of 3 was correct, the farm design shown in the wiki would not work image

Duplicate of #16473 Incorrect fix was in https://github.com/GTNewHorizons/GT5-Unofficial/pull/2642