GTNewHorizons / GT-New-Horizons-Modpack

New Modpack with Gregtech, Thaumcraft and Witchery
https://www.gtnewhorizons.com/
Other
1.01k stars 304 forks source link

Rocketdyne engine not initializing immediately at world load can cause explosion #17016

Open nullmana opened 2 months ago

nullmana commented 2 months ago

Your GTNH Discord Username

No response

Your Pack Version

2.6.1

Your Server

SP

Java Version

Java 17

Type of Server

None

Your Expectation

Rocketdyne engine being fed fuel by a fluid regulator at a consistent rate should consume fuel consistently

The Reality

When loading into the world, the engine may skip one or more seconds of fuel consumption before initializing, resulting in consuming several seconds of fuel all at once, which can cause an explosion if the resulting energy output is greater than what the dynamo hatch provides

Example: Feed 250/sec purple rocket fuel with boost for ~128,000 EU/t with a 16A IV dynamo. While the game is running, this is perfectly safe. If the game is reloaded, this can cause an explosion.

Your Proposal

Void the first tick of fuel if the engine is running when the world is loaded, or do not make the engine explode from overvolting when the multiblock is this unstable.

Final Checklist

Reflex18 commented 2 months ago

While completely unrelated to your issue. You should feed the rocket dyne per tick rather then per second. This is because the rocket dyne consumes fuel every second tick for a 50% boost to efficacy. So making sure the regulator is set to per tick rather then per second is a nice boost to effiency.

michaeldoylecs commented 2 months ago

This applies to the Universal Chemical Fuel Engine as well. (At least on 2.6)

EDIT: I've been made aware that this should be fixed for UCFE on nightly. https://github.com/GTNewHorizons/GoodGenerator/pull/256